Date: Mon, 11 Aug 2014 20:06:32 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 192597] New: [PATCH] net/GeoIP: geoipupdate.sh script non-functional Message-ID: <bug-192597-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192597 Bug ID: 192597 Summary: [PATCH] net/GeoIP: geoipupdate.sh script non-functional Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: mandree@FreeBSD.org Created attachment 145688 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=145688&action=edit Patch to create %%DATADIR%% before attempting download; general overhaul. Hi Adam, the geoipupdate.sh script is non-functional for me on a fresh ports-based install. Apparently we need to create "%%DATADIR%%" first, and the script can also do with enhanced error checking and refactoring. Patch attached -- the crucial point is the "mkdir -p" early, and the trap/rm -f/mv -f are to make the script more robust and ask less questions in adverse conditions. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-192597-13>