From owner-freebsd-mips@FreeBSD.ORG  Fri Jul  9 21:08:04 2010
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2D2C8106566C
	for <freebsd-mips@freebsd.org>; Fri,  9 Jul 2010 21:08:04 +0000 (UTC)
	(envelope-from juli@clockworksquid.com)
Received: from mail-vw0-f54.google.com (mail-vw0-f54.google.com
	[209.85.212.54])
	by mx1.freebsd.org (Postfix) with ESMTP id DD6968FC14
	for <freebsd-mips@freebsd.org>; Fri,  9 Jul 2010 21:08:03 +0000 (UTC)
Received: by vws6 with SMTP id 6so3735523vws.13
	for <freebsd-mips@freebsd.org>; Fri, 09 Jul 2010 14:07:58 -0700 (PDT)
Received: by 10.220.49.204 with SMTP id w12mr5569699vcf.103.1278709669124; 
	Fri, 09 Jul 2010 14:07:49 -0700 (PDT)
MIME-Version: 1.0
Sender: juli@clockworksquid.com
Received: by 10.220.188.69 with HTTP; Fri, 9 Jul 2010 14:07:28 -0700 (PDT)
In-Reply-To: <20100709.144631.1141490504242621103.imp@bsdimp.com>
References: <20100708.021250.1099368555950605809.imp@bsdimp.com> 
	<AANLkTilFZ4zAKqGcDKie6og5Nhrh9PU_Ta3uDoq7yexA@mail.gmail.com> 
	<AANLkTik8fBlxMyZ3AZETF_7DvlSpPsx2hozIWinRy0U0@mail.gmail.com> 
	<20100709.144631.1141490504242621103.imp@bsdimp.com>
From: Juli Mallett <jmallett@FreeBSD.org>
Date: Fri, 9 Jul 2010 14:07:28 -0700
X-Google-Sender-Auth: gYUut9JmUdy6n1NO_PlHSkSKzVM
Message-ID: <AANLkTimcCqP2SinyKJUqpT9l0j07AqGCLxMCuCGXc2wA@mail.gmail.com>
To: "M. Warner Losh" <imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-mips@freebsd.org
Subject: Re: Merging 64 bit changes to -HEAD - part 4
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Jul 2010 21:08:04 -0000

On Fri, Jul 9, 2010 at 13:46, M. Warner Losh <imp@bsdimp.com> wrote:
> pmap_map should likely have a comment to the effect:
> =A0* For memory that's directly mappable, we return the direct map
> =A0* address. =A0For other addresses, we create a map.

Doesn't it already?

 *	The value passed in '*virt' is a suggested virtual address for
 *	the mapping. Architectures which can support a direct-mapped
 *	physical to virtual region can return the appropriate address
 *	within that region, leaving '*virt' unchanged. Other
 *	architectures should map the pages starting at '*virt' and
 *	update '*virt' with the first usable address after the mapped
 *	region.

> : mips-ddb-64.patch (from Juli's branch)
> : Minor fixups for ddb support.
>
> Can you explain the casting for all the calls to kbdpeek*?

Yes.  sp is (or should be) a register_t.  You can't go from a
register_t to a pointer on n32.  Even if we don't intend to support
n32 kernels from head, we shouldn't make n32 harder by using the wrong
types without casts :)

Juli.