From owner-svn-src-all@freebsd.org Thu Jan 30 20:51:28 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6048F1FE7E8 for ; Thu, 30 Jan 2020 20:51:28 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 487svz4vGvz4f04 for ; Thu, 30 Jan 2020 20:51:27 +0000 (UTC) (envelope-from jroberson@jroberson.net) Received: by mail-pg1-x541.google.com with SMTP id j4so2277651pgi.1 for ; Thu, 30 Jan 2020 12:51:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jroberson-net.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=lNJXXJVgisz+eNZ7HJMPfNGPQ3CJY70H3/D8rEVQvnM=; b=SZctwgSVrgxxo5EaxTNW0V7gMloWz3i/0NWaiLG4q+5QAZsUqH4ucnJ/9APWVoCH9w zlNXDdgYHCKLtVmGkybtSsC4VFgZo3enFOYu5/2QRZbbvIRGDE9ukjuAaq5RhdJ15PtP M3zDObSFFSRmMXog1WXs9kvsAmXx31VW0rmjLaK81nniSvtzURpN1pt3P7xr7QRfI34N 3FCB0pT9d+Yrfv7LOfNBLwxB+1ndeHBTdxcgXrqQZn0xAMe5zZ0e8EpUdf5cdq0SAxlZ JFLGB/QqDi5Jc0V2bJDRqZzZlOd1D9zwECQoLCvc2FhX6LoRzaFqg0A8SgG/s0aNDVZy Z6zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=lNJXXJVgisz+eNZ7HJMPfNGPQ3CJY70H3/D8rEVQvnM=; b=eaQUICvFZ0JSX0W7M7arC9dwzwD4WPWeW9ktm2G0AFz9xj/wZJDSRShjSf/XjHN72m mJfk+vxrtdbJGIFaNWTyEvKGxTPOoCuxe+8cDOI7gr/BdXRURyxllpcRaU8ar4fxYyqw Wd0n8LDgYM3QxDdu31vKyNVv0eHYSB+Zr+SBtkbJUEQ9NXksnvPONF5LitxZQF1nU5yF OuoZqPR/iPPvS39zFxjYotaYXP4cyoocrEBZaiU6QudYneS1FZapMcI/Q7a3+3Kkn8C9 q9Lxt7yTYpQEptVsSxhd39EQprWHiQyJOlgSBb5uhACq/HqE7DDSVrim2eeMz857wp10 3YsQ== X-Gm-Message-State: APjAAAUJGX3UWiICbRjHtpOHF2gm8CE/K7Qb21atF0EHxIDQZfQiPbh9 SQdQ7qtOLqAUrlqHPDTqsHemlw== X-Google-Smtp-Source: APXvYqyq64SLt0j42UL5Ek677+5T+40uGBfmp8OvqBCoya/dBYenNx84m/2JT+65YBrBZhZcV/DbtQ== X-Received: by 2002:a62:1883:: with SMTP id 125mr6684199pfy.166.1580417485840; Thu, 30 Jan 2020 12:51:25 -0800 (PST) Received: from rrcs-76-81-105-82.west.biz.rr.com (rrcs-76-81-105-82.west.biz.rr.com. [76.81.105.82]) by smtp.gmail.com with ESMTPSA id h3sm7257423pji.9.2020.01.30.12.51.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jan 2020 12:51:25 -0800 (PST) Date: Thu, 30 Jan 2020 10:51:23 -1000 (HST) From: Jeff Roberson X-X-Sender: jroberson@desktop To: Gleb Smirnoff cc: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r357291 - in head/sys/dev: bwi bwn ipw iwi iwm iwn malo mwl ral rtwn/pci wi wpi wtap In-Reply-To: <20200130204322.GJ1268@FreeBSD.org> Message-ID: References: <202001301028.00UAS1s1063130@repo.freebsd.org> <20200130204322.GJ1268@FreeBSD.org> User-Agent: Alpine 2.21.9999 (BSF 287 2018-06-16) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 487svz4vGvz4f04 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=jroberson-net.20150623.gappssmtp.com header.s=20150623 header.b=SZctwgSV; dmarc=none; spf=none (mx1.freebsd.org: domain of jroberson@jroberson.net has no SPF policy when checking 2607:f8b0:4864:20::541) smtp.mailfrom=jroberson@jroberson.net X-Spamd-Result: default: False [-2.71 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[jroberson-net.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[jroberson.net]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[jroberson-net.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[1.4.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-0.91)[ip: (-0.71), ipnet: 2607:f8b0::/32(-2.03), asn: 15169(-1.78), country: US(-0.05)] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2020 20:51:28 -0000 On Thu, 30 Jan 2020, Gleb Smirnoff wrote: > On Thu, Jan 30, 2020 at 10:28:01AM +0000, Hans Petter Selasky wrote: > H> Author: hselasky > H> Date: Thu Jan 30 10:28:01 2020 > H> New Revision: 357291 > H> URL: https://svnweb.freebsd.org/changeset/base/357291 > H> > H> Log: > H> Widen EPOCH(9) usage in PCI WLAN drivers. > H> > H> Make sure all occurrences of ieee80211_input_xxx() in sys/dev are > H> covered by a network epoch section. Do not depend on the interrupt > H> handler nor any taskqueues being in a network epoch section. > H> > H> This patch should unbreak the PCI WLAN drivers after r357004. > H> > H> Pointy hat: glebius@ > H> Sponsored by: Mellanox Technologies > > Hey, I have reviewed all of them. > > The following drivers were not broken, and your change does 100% > recursive epoch_enter: > > bwi, ipw, iwi, iwm, iwn, ral, rtwn, wi, wpi > > The following drivers use taskq and would be fixed by D23408: > > bwn, malo, mwl, wtap > > P.S. A funny note about wtap. You modified even a function that > is a dead code - wtap_rx_deliver(). Gives some clue on quality > of your sweep over all drivers. I would strongly suggest that we not make more changes to this area without a discussion on a review to make sure we're all in agreement. There are some fine technical details which would benefit from multiple eyes and failing to act together is creating more conflict than is necessary. I volunteer to be on the reviews as an impartial third party. Thanks, Jeff > > -- > Gleb Smirnoff >