From owner-svn-ports-head@FreeBSD.ORG  Mon Jul 21 20:57:05 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 222E7F9F;
 Mon, 21 Jul 2014 20:57:05 +0000 (UTC)
Received: from mail-yh0-x236.google.com (mail-yh0-x236.google.com
 [IPv6:2607:f8b0:4002:c01::236])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id AC2F7233A;
 Mon, 21 Jul 2014 20:57:04 +0000 (UTC)
Received: by mail-yh0-f54.google.com with SMTP id v1so4486556yhn.13
 for <multiple recipients>; Mon, 21 Jul 2014 13:57:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=VHDtjxO1AawX0D0gTzecoUUxq3qhgPAiSyPuOkZXqNE=;
 b=lkdftLQ1lNALKYRTYS5PxtExCE6vjVCEvGcydOYY6pNy2bUxrOiiGf+CAL0GmJmpLX
 EBfJjfjJIYLKWSoRb4H1gLnZnwM1EqzjfxCFULXuqCiLrh757+5lp1LEW15fgesbAihC
 x3Pj3b8VLMB5ifZ5wYJpnbol5sJ/AD3si/S4phc9DPnu0rQT58r8MCzGkagUROK+zCmQ
 cHr6S242Ha1PTKXjX7OaRrhQ2g9gGBpsRGTcDFUhKC/FamMy+Fs6NgNOJWytPa+Deo1h
 /Uv/KIL2bcwXcObVW6Q6osqyaGlILF56UyHp+19RcdjF4FHU+at3sQ6XI7X91D381BJZ
 QnqA==
MIME-Version: 1.0
X-Received: by 10.236.42.137 with SMTP id j9mr12378568yhb.23.1405976223769;
 Mon, 21 Jul 2014 13:57:03 -0700 (PDT)
Sender: antoine.brodin.freebsd@gmail.com
Received: by 10.170.164.197 with HTTP; Mon, 21 Jul 2014 13:57:03 -0700 (PDT)
In-Reply-To: <201407212053.s6LKru8U037225@svn.freebsd.org>
References: <201407212053.s6LKru8U037225@svn.freebsd.org>
Date: Mon, 21 Jul 2014 22:57:03 +0200
X-Google-Sender-Auth: PmQqeC9QDPbM3V4PVpE9XqW-tv8
Message-ID: <CAALwa8=Pi14WpoGLjg53-9a64q2Xa=tZopc=xBDi+-wrnBYOiA@mail.gmail.com>
Subject: Re: svn commit: r362484 - head/www/WebMagick
From: Antoine Brodin <antoine@FreeBSD.org>
To: Adam Weinberger <adamw@freebsd.org>
Content-Type: text/plain; charset=UTF-8
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jul 2014 20:57:05 -0000

On Mon, Jul 21, 2014 at 10:53 PM, Adam Weinberger <adamw@freebsd.org> wrote:
> Author: adamw
> Date: Mon Jul 21 20:53:56 2014
> New Revision: 362484
> URL: http://svnweb.freebsd.org/changeset/ports/362484
> QAT: https://qat.redports.org/buildarchive/r362484/
>
> Log:
>   As suggested by ache, actually check for the presence of Image/Magick.pm and only barf if it
>   doesn't exist.
>
> Modified:
>   head/www/WebMagick/Makefile
>
> Modified: head/www/WebMagick/Makefile
> ==============================================================================
> --- head/www/WebMagick/Makefile Mon Jul 21 20:51:34 2014        (r362483)
> +++ head/www/WebMagick/Makefile Mon Jul 21 20:53:56 2014        (r362484)
> @@ -38,12 +38,15 @@ X11_BUILD_DEPENDS=  xlsfonts:${PORTSDIR}/
>  X11_RUN_DEPENDS=       xlsfonts:${PORTSDIR}/x11-fonts/xlsfonts
>  X11_CONFIGURE_ENV_OFF= with_x=no
>
> -pre-everything::
> -       @${ECHO_CMD}
> -       @${ECHO_CMD} ${PORTNAME} requires that ImageMagick be installed with the PERL option enabled.
> -       @${ECHO_CMD}
> +.include <bsd.port.pre.mk>
> +
> +do-configure:
> +       @if [ ! -f ${SITE_PERL}/${PERL_ARCH}/Image/Magick.pm ]; then \
> +               ${ECHO_CMD} ERROR: ImageMagick must be installed with the PERL option enabled; \
> +               ${FALSE}; \
> +       fi
>
>  pre-install:
>         @${MKDIR} ${STAGEDIR}${PREFIX}/www/data
>
> -.include <bsd.port.mk>
> +.include <bsd.port.post.mk>
>

Hi,

A custom do-configure looks really wrong..

Cheers,

Antoine