From owner-svn-src-all@FreeBSD.ORG Thu Dec 22 07:21:07 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 022A110656ED; Thu, 22 Dec 2011 07:21:07 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3E2D88FC13; Thu, 22 Dec 2011 07:21:05 +0000 (UTC) Received: by vcbfk1 with SMTP id fk1so11197969vcb.13 for ; Wed, 21 Dec 2011 23:21:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=4IK1w6Els7qqecXhUsxJjgdwjG7TJqU82l2S1U0Lscw=; b=VWoXC3ff/FTIK57MbLzB6h2x0xA/ZMZF1rPYetTRZ+iN0fHAI8+0voG3iYHVjdGajZ shckldPNWVVUWZ3osJqY/dSxFzZnBTIGzZuclnXePyw14OXMgpg1+nE3ic4Spc/6KXxF dZJIf1Hi49iMnivfc/xcQoTk/tEvQwcVWQ3dE= MIME-Version: 1.0 Received: by 10.220.232.10 with SMTP id js10mr6965728vcb.2.1324538465385; Wed, 21 Dec 2011 23:21:05 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.52.158.104 with HTTP; Wed, 21 Dec 2011 23:21:05 -0800 (PST) In-Reply-To: <20111221232754.GA51331@freebsd.org> References: <201112211716.pBLHGhDH078507@svn.freebsd.org> <201112211700.42772.jhb@freebsd.org> <20111221232754.GA51331@freebsd.org> Date: Wed, 21 Dec 2011 23:21:05 -0800 X-Google-Sender-Auth: 2R4B0FkT5EBifs6ry7nyTi8FsJQ Message-ID: From: Adrian Chadd To: Alexander Best Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric , John Baldwin Subject: Re: svn commit: r228785 - in head/sys/dev/ath/ath_hal: ar5210 ar5211 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2011 07:21:07 -0000 On 21 December 2011 15:27, Alexander Best wrote: >> I agree it should be reviewed, but if you are seriously depending on >> the fact that the shifted values are beyond the edge of the word boundary >> and so the result "wraps" to zero, then I'd question the sanity of your code. > > i disagree. > > the commits should stay. after all this is HEAD. this way all developers > running HEAD and with the appropriate ath hardware will test the changes. if > dim@ really broke something, people will notice. > > the changes should *not* be MFC'ed. but if no one complains until 10.0-RELEASE, > it's very unlikely he broke something. > > plus...does it make a different, if you test HEAD with the changes present or > test HEAD with the changes integrated via patches? > > one way or the other you can test the changes and *if* something broke, the > commits can be reverted. Hi, This makes a mockery of the concept of "maintainers" :-) The idea of committing stuff into directories that others actively maintain and claim responsibility of is a bit ridiculous. So here - I'm asking that the commits be reverted until I've sat down and tested it on the AR5210/AR5211 cards I've acquired. Thanks, Adrian