Date: Wed, 21 Dec 2011 23:21:05 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Alexander Best <arundel@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric <dim@freebsd.org>, John Baldwin <jhb@freebsd.org> Subject: Re: svn commit: r228785 - in head/sys/dev/ath/ath_hal: ar5210 ar5211 Message-ID: <CAJ-Vmon_z6enOqva_wcjh_Et211TEv_Zz-ANeWV4-eV=QB5iMw@mail.gmail.com> In-Reply-To: <20111221232754.GA51331@freebsd.org> References: <201112211716.pBLHGhDH078507@svn.freebsd.org> <CAJ-Vmont2wOF=TkT1CmZt4Gp0iOc7ZYmfQpjW=8j1=F5DQGNwQ@mail.gmail.com> <201112211700.42772.jhb@freebsd.org> <20111221232754.GA51331@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 December 2011 15:27, Alexander Best <arundel@freebsd.org> wrote: >> I agree it should be reviewed, but if you are seriously depending on >> the fact that the shifted values are beyond the edge of the word boundary >> and so the result "wraps" to zero, then I'd question the sanity of your code. > > i disagree. > > the commits should stay. after all this is HEAD. this way all developers > running HEAD and with the appropriate ath hardware will test the changes. if > dim@ really broke something, people will notice. > > the changes should *not* be MFC'ed. but if no one complains until 10.0-RELEASE, > it's very unlikely he broke something. > > plus...does it make a different, if you test HEAD with the changes present or > test HEAD with the changes integrated via patches? > > one way or the other you can test the changes and *if* something broke, the > commits can be reverted. Hi, This makes a mockery of the concept of "maintainers" :-) The idea of committing stuff into directories that others actively maintain and claim responsibility of is a bit ridiculous. So here - I'm asking that the commits be reverted until I've sat down and tested it on the AR5210/AR5211 cards I've acquired. Thanks, Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmon_z6enOqva_wcjh_Et211TEv_Zz-ANeWV4-eV=QB5iMw>