From owner-freebsd-arch Mon Jan 22 15:14:17 2001 Delivered-To: freebsd-arch@freebsd.org Received: from VL-MS-MR001.sc1.videotron.ca (relais.videotron.ca [24.201.245.36]) by hub.freebsd.org (Postfix) with ESMTP id E19B137B6C1 for ; Mon, 22 Jan 2001 15:13:58 -0800 (PST) Received: from jehovah ([24.201.144.31]) by VL-MS-MR001.sc1.videotron.ca (Netscape Messaging Server 4.15) with SMTP id G7L76V02.RSC; Mon, 22 Jan 2001 18:13:43 -0500 Message-ID: <008901c084c9$32485cf0$1f90c918@jehovah> From: "Bosko Milekic" To: "Dag-Erling Smorgrav" Cc: References: <015201c084aa$6c356800$1f90c918@jehovah> Subject: Re: Second zone allocator patch Date: Mon, 22 Jan 2001 18:15:23 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.00.2919.6700 X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2919.6700 Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Dag-Erling Smorgrav wrote: > "Bosko Milekic" writes: > > Dag-Erling Smorgrav wrote: > > > - use atomic operations for updating the statistics counters. > > Can you get away with grouping the changes to these counters while > > holding the zlist lock? If so, you can get rid of the necessity for the > > atomic() ops. > > Well, right now they're updated inside _zget(), which holds the zone > lock, and the zlist lock shouldn't be held while holding the zone lock > (it'll cause a lock order reversal if vm_zone_sysctl() runs at the > same time). Are atomic operations too expensive? Since these are just > statistics, can we get away with leaving them as they are, at the risk > of getting incorrect stats once in a while? Better be correct and use atomic*(), then. [...] > > > the Giant hackery in zinitna() and _zget(). > > The Giant hackery was not committed, btw - Jason objected. Since the > zone allocator still runs under Giant anyway, it shouldn't matter yet. What Giant hackery is this? If this is the KASSERT, that's not "hackery," it's a debugging and prevention aid. > DES > -- > Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message