Date: Mon, 18 Sep 2023 07:31:46 +0200 From: Martin Matuska <mm@FreeBSD.org> To: Alexander Motin <mav@FreeBSD.org>, Graham Perrin <grahamperrin@gmail.com>, freebsd-current@freebsd.org Cc: freebsd-stable@freebsd.org Subject: Re: vfs.zfs.bclone_enabled (was: FreeBSD 14.0-BETA2 Now Available) Message-ID: <8e4e4000-4680-0550-6772-32a6a3101761@FreeBSD.org> In-Reply-To: <7a6692de-f096-637d-fe48-d5fb93e54f8b@FreeBSD.org> References: <20230916002831.GU52318@FreeBSD.org> <02c53c2e-127b-33b4-e13d-f6f6589dd5fe@gmail.com> <7a6692de-f096-637d-fe48-d5fb93e54f8b@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
I vote for enabling block cloning on main :-) mm On 16. 9. 2023 19:14, Alexander Motin wrote: > On 16.09.2023 01:25, Graham Perrin wrote: >> On 16/09/2023 01:28, Glen Barber wrote: >>> o A fix for the ZFS block_cloning feature has been implemented. >> >> Thanks >> >> I see >> <https://github.com/openzfs/zfs/commit/5cc1876f14f90430b24f1ad2f231de936691940f>, >> with >> <https://github.com/freebsd/freebsd-src/commit/9dcf00aa404bb62052433c45aaa5475e2760f5ed>; >> in stable/14. >> >> As vfs.zfs.bclone_enabled is still 0 (at least, with 15.0-CURRENT >> n265350-72d97e1dd9cc): should we assume that additional fixes, not >> necessarily in time for 14.0-RELEASE, will be required before >> vfs.zfs.bclone_enabled can default to 1? > > I am not aware of any block cloning issues now. All this thread about > bclone_enabled actually started after I asked why it is still > disabled. Thanks to Mark Millard for spotting this issue I could fix, > but now we are back at the point of re-enabling it again. Since the > tunable does not even exist anywhere outside of FreeBSD base tree, I'd > propose to give this code another try here too. I see no point to > have it disabled at least in main unless somebody needs time to run > some specific tests first. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8e4e4000-4680-0550-6772-32a6a3101761>