From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Feb 12 06:10:12 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78221106564A for ; Sun, 12 Feb 2012 06:10:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 527828FC13 for ; Sun, 12 Feb 2012 06:10:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q1C6ACKx092351 for ; Sun, 12 Feb 2012 06:10:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q1C6ACnX092350; Sun, 12 Feb 2012 06:10:12 GMT (envelope-from gnats) Resent-Date: Sun, 12 Feb 2012 06:10:12 GMT Resent-Message-Id: <201202120610.q1C6ACnX092350@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Tony Sweeney Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 283CA1065670 for ; Sun, 12 Feb 2012 06:05:09 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id CE8588FC0C for ; Sun, 12 Feb 2012 06:05:09 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q1C659wT051293 for ; Sun, 12 Feb 2012 06:05:09 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q1C6598h051292; Sun, 12 Feb 2012 06:05:09 GMT (envelope-from nobody) Message-Id: <201202120605.q1C6598h051292@red.freebsd.org> Date: Sun, 12 Feb 2012 06:05:09 GMT From: Tony Sweeney To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/165023: [patch] devel/p4v port is marked broken and also stale X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Feb 2012 06:10:12 -0000 >Number: 165023 >Category: ports >Synopsis: [patch] devel/p4v port is marked broken and also stale >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Sun Feb 12 06:10:11 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Tony Sweeney >Release: (PC-BSD) 9.0 >Organization: None >Environment: FreeBSD dolt 9.0-RELEASE FreeBSD 9.0-RELEASE #3: Tue Dec 27 14:14:29 PST 2011 root@build9x64.pcbsd.org:/usr/obj/builds/amd64/pcbsd-build90/fbsd-source/9.0/sys/GENERIC amd64 >Description: The P4V port is marked as broken due to invalid distinfo. The changes in the attached shar file fix it for me. The 'port test' command successfully builds, installs and removes the port on the environment unamed above. The 'portlint' command issues two warnings: [root@dolt] /usr/ports/devel/p4v# portlint WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX. WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing them. 0 fatal errors and 2 warnings found. [root@dolt] /usr/ports/devel/p4v# I'm not entirely happy with this, but I couldn't get WRKSRC to function as advertised. I wasn't able to get the port system to use the appropriate work directory if I set DISTNAME and EXTRACT_SUFX as recommended (and as in the existing port). I may be overlooking something obvious. I took the trouble to download all available versions from ftp://ftp.perforce.com/perforce/r10.1/ and verify the checksums and sizes, but I have only been able to test the freebsd70x86_64 version. From what I can gather from the web site, this may be the final native FreeBSD version of P4V. I guess we're expected to use the Linux version if we want the newer features. It might be worth adding some words to the pkg-message to that effect. >How-To-Repeat: Try to build the port. >Fix: Remove the existing distinfo.* files and apply the attached shar file. Patch attached with submission follows: # This is a shell archive. Save it in a file, remove anything before # this line, and then unpack it by entering "sh file". Note, it may # create directories; files and directories will be owned by you and # have default permissions. # # This archive contains: # # /usr/ports/devel/p4v # /usr/ports/devel/p4v/pkg-descr # /usr/ports/devel/p4v/Makefile # /usr/ports/devel/p4v/distinfo.freebsd70x86 # /usr/ports/devel/p4v/distinfo.freebsd54x86 # /usr/ports/devel/p4v/distinfo.freebsd54x86_64 # /usr/ports/devel/p4v/distinfo.freebsd70x86_64 # /usr/ports/devel/p4v/distinfo.freebsd60x86 # /usr/ports/devel/p4v/distinfo.freebsd60x86_64 # echo c - /usr/ports/devel/p4v mkdir -p /usr/ports/devel/p4v > /dev/null 2>&1 echo x - /usr/ports/devel/p4v/pkg-descr sed 's/^X//' >/usr/ports/devel/p4v/pkg-descr << 'd8adec540bd09ab7c45b6acfd84f0805' XP4V, Perforce Visual Client, is a graphical user interface to XPerforce on FreeBSD, Mac OS X and Linux. P4V provides quick and Xeasy access to Perforce-managed files through a user interface Xthat is consistent across OS platforms. X XWWW: http://www.perforce.com/perforce/products/p4v.html d8adec540bd09ab7c45b6acfd84f0805 echo x - /usr/ports/devel/p4v/Makefile sed 's/^X//' >/usr/ports/devel/p4v/Makefile << 'df0ebc08c81a25933eb60c9709af1ce6' X# New ports collection makefile for: p4v X# Date created: 14 February 2004 X# Whom: bms@FreeBSD.org X# X# $FreeBSD: ports/devel/p4v/Makefile,v 1.33 2011/12/02 20:26:16 pav Exp $ X# X XPORTNAME= p4v XPORTVERSION= 2010.1.276058 XCATEGORIES= devel XMASTER_SITES= ftp://ftp.perforce.com/perforce/${P4VERSION}/bin.${PLATFORM}/ \ X http://filehost.perforce.com/perforce/${P4VERSION}/bin.${PLATFORM}/ XDISTFILES= p4v.tgz XDIST_SUBDIR= perforce/${PORTVERSION}/bin.${PLATFORM} X XMAINTAINER= gordon@FreeBSD.org XCOMMENT= Visual client for Perforce SCM X XRESTRICTED= Binary redistribution restrictions in effect X XONLY_FOR_ARCHS= amd64 i386 XNO_BUILD= yes XUSE_LDCONFIG= yes X XP4VERSION= r${PORTVERSION:S/^20//:C/\.[0-9]+$//} XDIST_SUBDIR= perforce/${PORTVERSION}/bin.${PLATFORM} XDISTINFO_FILE= ${MASTERDIR}/distinfo.${PLATFORM} X X.include X X.include "${.CURDIR}/../p4/Makefile.inc" X XP4V_BIN= \ X bin/assistant bin/p4merge bin/p4merge.bin bin/p4v bin/p4v.bin X XP4V_LIBS= \ X lib/p4v/qt4/lib/libQtCLuceneP4.so.4 \ X lib/p4v/qt4/lib/libQtCoreP4.so.4 \ X lib/p4v/qt4/lib/libQtGuiP4.so.4 \ X lib/p4v/qt4/lib/libQtHelpP4.so.4 \ X lib/p4v/qt4/lib/libQtMultimediaP4.so.4 \ X lib/p4v/qt4/lib/libQtNetworkP4.so.4 \ X lib/p4v/qt4/lib/libQtScriptP4.so.4 \ X lib/p4v/qt4/lib/libQtSqlP4.so.4 \ X lib/p4v/qt4/lib/libQtWebKitP4.so.4 \ X lib/p4v/qt4/lib/libQtXmlP4.so.4 \ X lib/p4v/qt4/lib/libQtXmlPatternsP4.so.4 \ X lib/p4v/qt4/plugins/accessible/libqtaccessiblewidgets.so \ X lib/p4v/qt4/plugins/graphicssystems/libqtracegraphicssystem.so \ X lib/p4v/qt4/plugins/imageformats/libqgif.so \ X lib/p4v/qt4/plugins/imageformats/libqico.so \ X lib/p4v/qt4/plugins/imageformats/libqjpeg.so \ X lib/p4v/qt4/plugins/imageformats/libqmng.so \ X lib/p4v/qt4/plugins/imageformats/libqsvg.so \ X lib/p4v/qt4/plugins/imageformats/libqtiff.so \ X lib/p4v/qt4/plugins/inputmethods/libqimsw-multi.so \ X lib/p4v/qt4/plugins/sqldrivers/libqsqlite.so X XP4V_RESOURCES= \ X lib/p4v/P4VResources/p4d \ X lib/p4v/P4VResources/p4ob \ X lib/p4v/P4VResources/translations/assistant_ja.qm \ X lib/p4v/P4VResources/translations/qt_ja.qm \ X lib/p4v/P4VResources/translations/p4v_ja.qm \ X lib/p4v/P4VResources/translations/p4v_en.qm \ X lib/p4v/P4VResources/translations/p4merge_ja.qm \ X lib/p4v/P4VResources/translations/p4merge_en.qm \ X lib/p4v/P4VResources/translations/p4admin_ja.qm \ X lib/p4v/P4VResources/translations/p4admin_en.qm \ X lib/p4v/P4VResources/translations/msg_ja.txt \ X lib/p4v/P4VResources/images.rcc \ X lib/p4v/P4VResources/icons/p4v_16_low.png \ X lib/p4v/P4VResources/icons/p4v_32_high.png \ X lib/p4v/P4VResources/icons/p4v_32_low.png \ X lib/p4v/P4VResources/icons/p4v_48_high.png \ X lib/p4v/P4VResources/p4vhelp/p4vhelp_ja.qhc \ X lib/p4v/P4VResources/p4vhelp/p4vhelp_ja.qch \ X lib/p4v/P4VResources/p4vhelp/p4vhelp_en.qhc \ X lib/p4v/P4VResources/p4vhelp/p4vhelp_en.qch \ X lib/p4v/P4VResources/p4vhelp/p4v-gs.pdf \ X lib/p4v/P4VResources/p4vhelp/p4v-gs_ja.pdf \ X lib/p4v/P4VResources/p4mergehelp/p4mergehelp_ja.qhc \ X lib/p4v/P4VResources/p4mergehelp/p4mergehelp_ja.qch \ X lib/p4v/P4VResources/p4mergehelp/p4mergehelp_en.qhc \ X lib/p4v/P4VResources/p4mergehelp/p4mergehelp_en.qch \ X lib/p4v/P4VResources/p4adminhelp/p4adminhelp_ja.qhc \ X lib/p4v/P4VResources/p4adminhelp/p4adminhelp_ja.qch \ X lib/p4v/P4VResources/p4adminhelp/p4adminhelp_en.qhc \ X lib/p4v/P4VResources/p4adminhelp/p4adminhelp_en.qch \ X lib/p4v/P4VResources/examples/basic_p4vdefaults.xml \ X lib/p4v/P4VResources/examples/basic_p4vfeatures.xml \ X lib/p4v/P4VResources/examples/p4vdefaults.xml \ X lib/p4v/P4VResources/examples/p4vfeatures.xml X XP4V_DIRS= \ X lib/p4v/qt4/plugins/sqldrivers \ X lib/p4v/qt4/plugins/inputmethods \ X lib/p4v/qt4/plugins/imageformats \ X lib/p4v/qt4/plugins/graphicssystems \ X lib/p4v/qt4/plugins/accessible \ X lib/p4v/qt4/plugins \ X lib/p4v/qt4/lib \ X lib/p4v/qt4 \ X lib/p4v/P4VResources/translations \ X lib/p4v/P4VResources/p4vhelp \ X lib/p4v/P4VResources/p4mergehelp \ X lib/p4v/P4VResources/p4adminhelp \ X lib/p4v/P4VResources/icons \ X lib/p4v/P4VResources/examples \ X lib/p4v/P4VResources \ X lib/p4v X XPLIST_DIRS+= ${P4V_DIRS} XPLIST_FILES+= ${P4V_BIN} ${P4V_LIBS} ${P4V_RESOURCES} X Xdo-install: X ${INSTALL_PROGRAM} ${WRKSRC}/bin/assistant ${PREFIX}/bin X ${INSTALL_PROGRAM} ${WRKSRC}/bin/p4merge.bin ${PREFIX}/bin X ${INSTALL_PROGRAM} ${WRKSRC}/bin/p4v.bin ${PREFIX}/bin X ${INSTALL_SCRIPT} ${WRKSRC}/bin/p4merge ${PREFIX}/bin X ${INSTALL_SCRIPT} ${WRKSRC}/bin/p4v ${PREFIX}/bin X.for _DIR in ${P4V_DIRS} X ${MKDIR} ${PREFIX}/${_DIR} X.endfor X.for _LIBFILE in ${P4V_LIBS} X ${INSTALL_PROGRAM} ${WRKSRC}/${_LIBFILE} ${PREFIX}/${_LIBFILE} X.endfor X.for _RESOURCE in ${P4V_RESOURCES} X ${INSTALL_DATA} ${WRKSRC}/${_RESOURCE} ${PREFIX}/${_RESOURCE} X.endfor X X.include df0ebc08c81a25933eb60c9709af1ce6 echo x - /usr/ports/devel/p4v/distinfo.freebsd70x86 sed 's/^X//' >/usr/ports/devel/p4v/distinfo.freebsd70x86 << 'ab259903e38a62ef2bd0c3fc6e2d8a17' XSHA256 (perforce/2010.1.276058/bin.freebsd70x86/p4v.tgz) = f9f840d4a6055246d8f2a8e5e8824a4848e17026c169a5cfbd4e13f6e6554f13 XSIZE (perforce/2010.1.276058/bin.freebsd70x86/p4v.tgz) = 33745072 ab259903e38a62ef2bd0c3fc6e2d8a17 echo x - /usr/ports/devel/p4v/distinfo.freebsd54x86 sed 's/^X//' >/usr/ports/devel/p4v/distinfo.freebsd54x86 << '11de78992ff8ee9c17ea95c6a47a982b' XSHA256 (perforce/2010.1.276058/bin.freebsd54x86/p4v.tgz) = c5969844053b5cd5afefb2c055a8974ef34d9c74f551de1ebbaa8db91f4915ad XSIZE (perforce/2010.1.276058/bin.freebsd54x86/p4v.tgz) = 37959320 11de78992ff8ee9c17ea95c6a47a982b echo x - /usr/ports/devel/p4v/distinfo.freebsd54x86_64 sed 's/^X//' >/usr/ports/devel/p4v/distinfo.freebsd54x86_64 << 'fcae7afcbb83af3a2f61b8ba4daa6d4f' XSHA256 (perforce/2010.1.276058/bin.freebsd54x86_64/p4v.tgz) = 97f58085544a9f240ff9c65601f286fcbe789e8dd3dffbe635cbb0aea706b1db XSIZE (perforce/2010.1.276058/bin.freebsd54x86_64/p4v.tgz) = 38326440 fcae7afcbb83af3a2f61b8ba4daa6d4f echo x - /usr/ports/devel/p4v/distinfo.freebsd70x86_64 sed 's/^X//' >/usr/ports/devel/p4v/distinfo.freebsd70x86_64 << '08ac2ec2efc77d18bce800035cbfe95f' XSHA256 (perforce/2010.1.276058/bin.freebsd70x86_64/p4v.tgz) = 953ee299d4aa96f4d9a2e7d9ba42d73a53f0404b9c42c491c9859598354fa21f XSIZE (perforce/2010.1.276058/bin.freebsd70x86_64/p4v.tgz) = 33818177 08ac2ec2efc77d18bce800035cbfe95f echo x - /usr/ports/devel/p4v/distinfo.freebsd60x86 sed 's/^X//' >/usr/ports/devel/p4v/distinfo.freebsd60x86 << '842d740632fe6b3d6a9f1e7ba80aecec' XSHA256 (perforce/2010.1.276058/bin.freebsd60x86/p4v.tgz) = 5aa4569944f1ac385b5f32312fc57f0c4db2c75bca43773d4701ce05850ab815 XSIZE (perforce/2010.1.276058/bin.freebsd60x86/p4v.tgz) = 37722883 842d740632fe6b3d6a9f1e7ba80aecec echo x - /usr/ports/devel/p4v/distinfo.freebsd60x86_64 sed 's/^X//' >/usr/ports/devel/p4v/distinfo.freebsd60x86_64 << '5dfa09edd01b76ee1d45fd92b4db522c' XSHA256 (perforce/2010.1.276058/bin.freebsd60x86_64/p4v.tgz) = 5ce9706248e1b6d751aed7facbf6bfed7e0690900bb6f6f9372fd3c35dc73248 XSIZE (perforce/2010.1.276058/bin.freebsd60x86_64/p4v.tgz) = 38086577 5dfa09edd01b76ee1d45fd92b4db522c exit >Release-Note: >Audit-Trail: >Unformatted: