Date: Sun, 31 May 2009 23:08:28 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Dmitry Morozovsky <marck@rinet.ru> Cc: Pawel Jakub Dawidek <pjd@freebsd.org>, freebsd-rc@freebsd.org Subject: Re: svn commit: r193112 - head/etc/rc.d Message-ID: <4A23705C.3020603@FreeBSD.org> In-Reply-To: <alpine.BSF.2.00.0905312343510.19894@woozle.rinet.ru> References: <200905301938.n4UJcpbF017191@svn.freebsd.org> <alpine.BSF.2.00.0905311419080.30849@woozle.rinet.ru> <4A22CFA1.3050408@FreeBSD.org> <alpine.BSF.2.00.0905312343510.19894@woozle.rinet.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Dmitry Morozovsky wrote: > On Sun, 31 May 2009, Doug Barton wrote: > > DB> Dmitry Morozovsky wrote: > DB> > Doug, > DB> > > DB> > On Sat, 30 May 2009, Doug Barton wrote: > DB> > > DB> > DB> Author: dougb > DB> > DB> Date: Sat May 30 19:38:51 2009 > DB> > DB> New Revision: 193112 > DB> > DB> URL: http://svn.freebsd.org/changeset/base/193112 > DB> > DB> > DB> > DB> Log: > DB> > DB> As previously advertised, remove this script prior to the 8.0 branch. > DB> > > DB> > Was there an agreement what should one do with dumping to gmirror (see > DB> > sbin/geom/class/mirror/gmirror.8) ? > DB> > DB> I'm not familiar with that issue, but it sounds like something that > DB> needs its own rc.d script. If someone who knows what is supposed to > DB> happen wants to write something up and send it to the freebsd-rc@ list > DB> I'll be glad to help review it. > > Something like (checks should be added, yeah) This is fine, but for consistency with the other stuff in rc.d the name of the script, the value of $name, and the PROVIDE should all be the same. I would name it something like gmsc and in etc/defaults/rc.conf (and probably in the script itself) add a comment indicating what it's for. Not sure what you mean by "checks should be added," I'm not familiar with gmirror at all. But it looks like you're on the right track, yes. Doug > #!/bin/sh > # > # $FreeBSD$ > # > > # BEFORE: savecore > # PROVIDE: gmirror-savecore > # KEYWORD: nojail > > . /etc/rc.subr > > name="gmirror_savecore" > start_cmd="gmsavecore_start" > stop_cmd=":" > > gmsavecore_start() > { > gmirror configure -b prefer /dev/dumpdev > } > > load_rc_config $name > run_rc_command "$1" > > possibly? > -- This .signature sanitized for your protection
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A23705C.3020603>