From owner-svn-src-all@freebsd.org Tue Apr 19 06:54:11 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C9D31B14699 for ; Tue, 19 Apr 2016 06:54:11 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: from mail-wm0-x22e.google.com (mail-wm0-x22e.google.com [IPv6:2a00:1450:400c:c09::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 673D01186 for ; Tue, 19 Apr 2016 06:54:11 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: by mail-wm0-x22e.google.com with SMTP id u206so12385973wme.1 for ; Mon, 18 Apr 2016 23:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to; bh=GN52DM9fML5+aU4RmAfwPJogjNdTzcSUcHXp/Qu4eyg=; b=AJPWGSsk0pW/VQQZvtvSO/zflBnoPrxUZRuHbdZqJFpKgB72OGsKWOHmNzG0r67Van O/ZXfGWppnv4WHTJ8wnpETLxQ6WSTODam+eeSw7CEEqprPmMs3v0yHuFNo5EN0cDbUyQ XqHy5u00jzPwiCqQ9JhbvtXnQW570zWgI3P0F9LWd0wnzGZu2nNGss52dBEmtKbcSB6S cLwAdTHkLIAPslfKVNvVeVUGzXwRIhNT6xtKGshXu3sx7R9JtWCQuWI1ansH++Sqvn7v cj2vzImg1QOH/xxXN5vhKzdNPmyA3hIIcHuWa7t178Hug9JlyUqAudWrAmqchWFPnFNN oiVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=GN52DM9fML5+aU4RmAfwPJogjNdTzcSUcHXp/Qu4eyg=; b=WF0fnTBM84BVjNM5bfog3V5lwlNVR946yYfH19wu9+T2VVGy7o+AsnGXdni5c6guvv /pofhZYUy6ifakTSiPSMWlpJ6gt92J9FJ5F2cMFMB9bGsaaHzxaElMqfI0rZDBCXrk+B fq0kOa3L+noQYUsqYH48380VNUBxgXSmAlJodIZomrHu5RmkgXetjAhF5Sd9qsIg/+EC i0PEo9Y67VWSMYKSo00qWEY5DyOiJobHSRmYlBXLgf2rs4OSoW2u9Y26MOQ2jJS/7INK aKJ15+Ab4LfBSiisLZSsa64LJecLmX50pDKIyrJps7M+slV7026nI5fp51072HooVKGK Xzqg== X-Gm-Message-State: AOPr4FVV3U1kp5Eal1P7BO+YWH2P8n7f0Hb5vjMH70d8HJ/VPuSFDj0BXym4WOkRfKuhy9fM X-Received: by 10.28.180.133 with SMTP id d127mr1986795wmf.45.1461048849208; Mon, 18 Apr 2016 23:54:09 -0700 (PDT) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id d1sm2541823wmh.18.2016.04.18.23.54.07 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 18 Apr 2016 23:54:08 -0700 (PDT) Subject: Re: svn commit: r298244 - head/sbin/dumpon To: araujo@FreeBSD.org, Pedro Giffuni References: <201604190428.u3J4SP2w044552@repo.freebsd.org> <53a3202e-c144-b7d0-02f1-a7f4364d594e@FreeBSD.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Steven Hartland Message-ID: <5715D615.8020806@multiplay.co.uk> Date: Tue, 19 Apr 2016 07:54:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Apr 2016 06:54:11 -0000 On 19/04/2016 06:01, Marcelo Araujo wrote: > > > 2016-04-19 12:58 GMT+08:00 Pedro Giffuni >: > > > > On 04/18/16 23:28, Marcelo Araujo wrote: > > Author: araujo > Date: Tue Apr 19 04:28:25 2016 > New Revision: 298244 > URL: https://svnweb.freebsd.org/changeset/base/298244 > > Log: > Use nitems() instead of sizeof(name) / sizeof(*name). > > MFC after: 2 weeks. > > > FWIW, while I see why it makes sense to make these cosmetic > changes, it's probably too much to MFC them. > > At least I have no plans to merge the ones I've made since > they are non-functional. > > Pedro. > > > I was thinking to MFC it at once(less work)! As now I'm > checking/committing one by one. > Also not MFC'ing is likely to make it much harder to MFC other functional changes in the same area, so if they are easy then I'd say do it :) Regards Steve