From owner-freebsd-current Wed Jan 27 22:00:02 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id WAA18550 for freebsd-current-outgoing; Wed, 27 Jan 1999 22:00:02 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from apollo.backplane.com (apollo.backplane.com [209.157.86.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA18502 for ; Wed, 27 Jan 1999 22:00:00 -0800 (PST) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.9.2/8.9.1) id VAA93563; Wed, 27 Jan 1999 21:59:53 -0800 (PST) (envelope-from dillon) Date: Wed, 27 Jan 1999 21:59:53 -0800 (PST) From: Matthew Dillon Message-Id: <199901280559.VAA93563@apollo.backplane.com> To: Bruce Evans Cc: archie@whistle.com, current@FreeBSD.ORG Subject: Re: kern/subr_scanf array index of signed char References: <199901280424.PAA01617@godzilla.zeta.org.au> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG :> Actually, it could very well be that I don't. I didn't want to spend :> the time to check to see if the compiler warned on unsigned-char array :> indexes. You can change it back if unsigned char array indexes do not :> produce a warning. : :Sloppy thinking. How would you know if you fixed the bug unless you checked :that you fixed the bug instead of breaking the warning? The bug was that :on systems with signed chars, *inp gave negative array indexes if the :caller passes a format string with negative characters in certain positions. :There are still lots of related isfoo(*inp) bugs. All these bugs are more :serious in the userland. : :Bruce Oh come on, give me some credit -- I knew I fixed the bug by casting it to unsigned char. But after spending over 8 hours working the files over so people compiling the kernel don't get overwhelmed with warnings I was getting a bit fermented in the chair. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message