From owner-svn-src-all@freebsd.org Wed Jul 8 11:00:50 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B1BD995066; Wed, 8 Jul 2015 11:00:50 +0000 (UTC) (envelope-from cochard@gmail.com) Received: from mail-la0-x230.google.com (mail-la0-x230.google.com [IPv6:2a00:1450:4010:c03::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 111221FDE; Wed, 8 Jul 2015 11:00:50 +0000 (UTC) (envelope-from cochard@gmail.com) Received: by lagx9 with SMTP id x9so222646655lag.1; Wed, 08 Jul 2015 04:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=YL2IUtj7wHC0FHPodHCslVg0O9tTX2oO+yj7CW7siCo=; b=l6DYutf+AWl22vyvZlmfFyovlD5XQJTAohFQM1sKzNPa4lwsIgyuuExky2siywzTuC 2CvJf3hX9YYGnxT8qpu4Rk85cmGqq8rsjd5zqTSPhYbQW7tSLHwSBexBIMqudYFE9NiO Oa+NlK+jGyinrvcH0fWSW2AlmqnV4kx0rpXTMSBn+pQdmYtFMsqkYmfLeOgFlE3laznS 0RGsWA61CIVKzvz3w8+Vf3usaoVOpqavYLjLOWM5UTrBHcMbUvqEveUaWiGOWFD2toxc JFN03dNv++5W0CTkw1XRnnXA7lelf7qVNp9m0fndd73oS6kMuSxbOmdFMldfz4Tlv7om m4Ag== X-Received: by 10.112.210.9 with SMTP id mq9mr8846526lbc.4.1436353247936; Wed, 08 Jul 2015 04:00:47 -0700 (PDT) MIME-Version: 1.0 Sender: cochard@gmail.com Received: by 10.152.135.173 with HTTP; Wed, 8 Jul 2015 04:00:28 -0700 (PDT) In-Reply-To: <201507021810.t62IAgCc003272@repo.freebsd.org> References: <201507021810.t62IAgCc003272@repo.freebsd.org> From: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= Date: Wed, 8 Jul 2015 13:00:28 +0200 X-Google-Sender-Auth: cRlq4mpnlk4MLRu1TBkugSwxSHE Message-ID: Subject: Re: svn commit: r285051 - head/sys/netinet To: =?UTF-8?Q?Ermal_Lu=C3=A7i?= Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 11:00:50 -0000 On Thu, Jul 2, 2015 at 8:10 PM, Ermal Lu=C3=A7i wrote: > Author: eri > Date: Thu Jul 2 18:10:41 2015 > New Revision: 285051 > URL: https://svnweb.freebsd.org/changeset/base/285051 > > Log: > Avoid doing multiple route lookups for the same destination IP during > forwarding > > ip_forward() does a route lookup for testing this packet can be sent to > a known destination, > it also can do another route lookup if it detects that an ICMP redirect > is needed, > it forgets all of this and handovers to ip_output() to do the same > lookup yet again. > > This optimisation just does one route lookup during the forwarding path > and handovers that to be considered by ip_output(). > > =E2=80=8BThanks, This bring good improvement regarding simple forwarding (value in paquet-per-second, smallest size, on a Netgate RCC-VE 4860): x r285046.pps.forwarding (IPSEC compiled but not used) + r285051.pps.forwarding (IPSEC compiled but not used) +--------------------------------------------------------------------------= + | += | |xxx xx + +++= | ||_M_A__| = | | |_A|= | +--------------------------------------------------------------------------= + N Min Max Median Avg Stddev x 5 397733 406951 399300 401613.8 4324.9755 + 5 478095 482079 480869 480543.6 1666.0282 Difference at 95.0% confidence 78929.8 +/- 4779.72 19.6532% +/- 1.19013% (Student's t, pooled s =3D 3277.27) But how this patch reduce fastforwarding performance in the same time? x r285046.pps.fastforwarding (IPSEC compiled but not used) + r285051.pps.fastforwarding (IPSEC compiled but not used) +--------------------------------------------------------------------------= + | + + + + x x + x x x= | | |__________________A_______M__________| = | ||_________M______A________________| = | +--------------------------------------------------------------------------= + N Min Max Median Avg Stddev x 5 742683 754709 750940 749015.6 4944.9059 + 5 736459 747593 738197 740112.4 4511.1611 Difference at 95.0% confidence -8903.2 +/- 6902.82 -1.18865% +/- 0.921585% (Student's t, pooled s =3D 4733) Regards, Olivier =E2=80=8B