From owner-freebsd-current@FreeBSD.ORG  Wed Nov 19 01:08:46 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 79A9D16A4CE
	for <freebsd-current@freebsd.org>;
	Wed, 19 Nov 2003 01:08:46 -0800 (PST)
Received: from ntmk.tagil.ru (ntmk.tagil.ru [195.151.0.193])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8D09C43FBF
	for <freebsd-current@freebsd.org>;
	Wed, 19 Nov 2003 01:08:44 -0800 (PST)	(envelope-from boris@ntmk.ru)
Received: from ntmk.ru (boris.nikom.ru [10.1.16.195])
	by ntmk.tagil.ru (8.9.3/8.9.1) with ESMTP id OAA64155;
	Wed, 19 Nov 2003 14:08:40 +0500 (YEKT)
Message-ID: <3FBB3317.4090001@ntmk.ru>
Date: Wed, 19 Nov 2003 14:08:39 +0500
From: Boris Kovalenko <boris@ntmk.ru>
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.4) Gecko/20030624
X-Accept-Language: ru, en-us, en
MIME-Version: 1.0
To: Michael Bretterklieber <mbretter@a-quadrat.at>,
	freebsd-current <freebsd-current@freebsd.org>
References: <3FBAEAC1.7090709@tagnet.ru>
	<20031119071703.GA38863@pit.databus.com> <3FBB1DF3.1050706@ntmk.ru>
	<Pine.WNT.4.58.0311190851470.1928@BRUTUS> <3FBB2743.8040508@ntmk.ru>
	<Pine.WNT.4.58.0311190932020.1928@BRUTUS>
In-Reply-To: <Pine.WNT.4.58.0311190932020.1928@BRUTUS>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: ppp RADIUS accounting bug
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Nov 2003 09:08:46 -0000


>The RFC says:
>
>5.4.  Acct-Output-Octets
>
>blabla
>
>can only be
>      present in Accounting-Request records where the Acct-Status-Type
>      is set to Stop.
>
>It looks like, that these counters must not present in accounting updates.
>
You are right, but your words - "but a patch could be written :-)". 
Again, I'm talking not about UPDATE packets and presence of any 
attributes in RADIUS requests. I'm talking about wrong handling of 
Acct-Input-Octets & Acct-Output-Octets with current PPP RADIUS 
implementation. How this will be done, by implementing RFC2869 support 
or just by resending STOP request N times is not so important, but 
somehow this should be done. I may try to write patch myself, but I'm 
looking for someone who supervises my patch and commit it if no problems 
will be founded.

Regards,
    Boris