From owner-svn-src-all@FreeBSD.ORG Tue Aug 13 19:37:59 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 203D574E; Tue, 13 Aug 2013 19:37:59 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id F2F922F78; Tue, 13 Aug 2013 19:37:55 +0000 (UTC) Received: from alph.d.allbsd.org (p2049-ipbf1102funabasi.chiba.ocn.ne.jp [122.26.101.49]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r7DJbTp4083052 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 14 Aug 2013 04:37:39 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.5/8.14.5) with ESMTP id r7DJbSpE018203; Wed, 14 Aug 2013 04:37:29 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Wed, 14 Aug 2013 04:25:57 +0900 (JST) Message-Id: <20130814.042557.877689080765344354.hrs@allbsd.org> To: gjb@FreeBSD.org Subject: Re: svn commit: r254224 - head/share/man/man7 From: Hiroki Sato In-Reply-To: <201308111857.r7BIvRSq080970@svn.freebsd.org> References: <201308111857.r7BIvRSq080970@svn.freebsd.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Wed_Aug_14_04_25_58_2013_043)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Wed, 14 Aug 2013 04:37:39 +0900 (JST) X-Spam-Status: No, score=-90.6 required=13.0 tests=CONTENT_TYPE_PRESENT, DIRECTOCNDYN,DYN_PBL,RCVD_IN_PBL,SPF_SOFTFAIL,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Aug 2013 19:37:59 -0000 ----Security_Multipart(Wed_Aug_14_04_25_58_2013_043)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Glen Barber wrote in <201308111857.r7BIvRSq080970@svn.freebsd.org>: gj> +.It Va SVNROOT gj> +The gj> +.Xr svn 1 gj> +host used to check out the various trees. gj> Defaults to gj> -.Pa svn://svn.freebsd.org . gj> -.It Ev SVNROOTSRC gj> -The URL of the FreeBSD SVN source repository. gj> +.Pa svn://svn.FreeeBSD.org . gj> +.It Va SRCBRANCH gj> +The gj> +.Li src/ gj> +branch to use. gj> Defaults to gj> -.Pa ${SVNROOTBASE}/base . gj> -.It Ev SVNROOTDOC gj> -The URL of the FreeBSD SVN doc repository. gj> +.Va head/ . gj> +.It Va DOCBRANCH gj> +The gj> +.Li doc/ gj> +branch to use. gj> Defaults to gj> -.Pa ${SVNROOTBASE}/doc . gj> -.It Ev SVNROOTPORTS gj> -The URL of the FreeBSD SVN ports repository. gj> +.Va head/ . gj> +.It Va PORTBRANCH gj> +The gj> +.Li ports/ gj> +branch to use. gj> Defaults to gj> -.Pa ${SVNROOTBASE}/ports . gj> -.It Ev BRANCHDOC gj> -The branch name of the FreeBSD SVN doc repository. gj> +.Va head/ . gj> +.It Va SRCREVISION gj> +The revision of the gj> +.Li src/ gj> +tree to use. gj> +Defaults to the current top of tree revision. gj> +.It Va DOCREVISION gj> +The revision of the gj> +.Li doc/ gj> +tree to use. gj> +Defaults to the current top of tree revision. gj> +.It Va PORTREVISION Why separation between revision and branch is needed? I intentionally dropped this part from your old patch to generate-release.sh because branch and revision number can be specified like releng/9.2@NNN in a single variable. An incorrect configuration of the two variables do not always cause a fatal error, so specification in fewer number of variables is more foolproof. gj> +.It Va TARGET gj> +The target machine type for the release. gj> +Defaults to the current machine type. gj> +.It Va TARGET_ARCH gj> +The target machine architecture for the release. gj> +Defaults to the value of gj> +.Va TARGET . gj> +.Pp Please remove default configuration of these variables from release.sh. The reasonable defaults are already set in src/Makefile and setting TARGET_ARCH=$TARGET by default is simply wrong. Also, get_rev_branch() is redundant. gj> +Defaults to setting the number of gj> +.Xr make 1 gj> +jobs gj> +.Pq Ar -j gj> +to half the number of CPUs available on the system. Did you try this on a uniprocessor machine? -- Hiroki ----Security_Multipart(Wed_Aug_14_04_25_58_2013_043)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlIKiEYACgkQTyzT2CeTzy1jZwCgoWVFE2/vrFBSTDCdcsnTDWgu 97sAn3ka5P4LaQsvp7706Z5k4yUIpLBh =4PJo -----END PGP SIGNATURE----- ----Security_Multipart(Wed_Aug_14_04_25_58_2013_043)----