From owner-svn-src-head@freebsd.org  Tue Aug 21 21:26:30 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0D8C0107FA50;
 Tue, 21 Aug 2018 21:26:30 +0000 (UTC)
 (envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (glebi.us [198.45.61.253])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 913FF96E21;
 Tue, 21 Aug 2018 21:26:29 +0000 (UTC)
 (envelope-from glebius@freebsd.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id w7LLQSAa055046
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Tue, 21 Aug 2018 14:26:28 -0700 (PDT)
 (envelope-from glebius@freebsd.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id w7LLQSl7055045;
 Tue, 21 Aug 2018 14:26:28 -0700 (PDT)
 (envelope-from glebius@freebsd.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@freebsd.org using -f
Date: Tue, 21 Aug 2018 14:26:28 -0700
From: Gleb Smirnoff <glebius@freebsd.org>
To: Navdeep Parhar <np@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r337932 - in head/sys: net netinet
Message-ID: <20180821212628.GN27633@FreeBSD.org>
References: <201808162346.w7GNkc2p006822@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201808162346.w7GNkc2p006822@repo.freebsd.org>
User-Agent: Mutt/1.10.0 (2018-05-17)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Aug 2018 21:26:30 -0000

  Navdeep,

On Thu, Aug 16, 2018 at 11:46:38PM +0000, Navdeep Parhar wrote:
N> Author: np
N> Date: Thu Aug 16 23:46:38 2018
N> New Revision: 337932
N> URL: https://svnweb.freebsd.org/changeset/base/337932
N> 
N> Log:
N>   Add the ability to look up the 3b PCP of a VLAN interface.  Use it in
N>   toe_l2_resolve to fill up the complete vtag and not just the vid.
N>   
N>   Reviewed by:	kib@
N>   MFC after:	1 week
N>   Sponsored by:	Chelsio Communications
N>   Differential Revision:	https://reviews.freebsd.org/D16752
...
N> +static int
N> +vlan_pcp(struct ifnet *ifp, uint16_t *pcpp)
N> +{
N> +	struct ifvlan *ifv;
N> +
N> +	if (ifp->if_type != IFT_L2VLAN)
N> +		return (EINVAL);
N> +	ifv = ifp->if_softc;
N> +	*pcpp = ifv->ifv_pcp;
N> +	return (0);
N> +}

Is there any good reason not to assert that ifp->if_type == IFT_L2VLAN?

-- 
Gleb Smirnoff