From nobody Sun Apr 19 10:42:29 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fz4vG5qGfz6bN5l for ; Sun, 19 Apr 2026 10:42:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fz4vG17dXz3C7G for ; Sun, 19 Apr 2026 10:42:34 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776595354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fHjz2Ear2tFAA+clX0rA6fvQDkCU+KneWP4NUq7Ofl4=; b=sRg7WNdLeO8D7DMbgrgPvOhdlpToKU2nIrX4FNcqMKRYBytOoWbOfLam2KTb8rJsCwuiPs 0+ScjE/sKQs8oNNjf8/zfwlRQZ7n4VXqp1s3sadrIn3T6Yc6PnQ42VpUVthvgHzAi2xEC/ gGcibWcxLYmx92li8eIoBiZmCDbj+YnhCbyLZm850ge6pcGFTbajvCOLL7oYyKwo5uiSzH y8QuY4AhNVnnLoOwsc4qJ086z0wV9wk2tORvKMDYRov42pVPLhuZZ6UpwnDxIRdx3WZ8Ox xzqZQQfGEUooMg9SuN7Ci0Et4s3xa7K+5YSXQDxEX0FhjlEZ4wdkWfzKSmo19A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776595354; a=rsa-sha256; cv=none; b=mmGhkLlIxECQxj0+wZZWo1WNuFqA8pwiW4ewCqTkIfZLydIkEYLlkjfHUSCA/joF876wu5 8YJMZzgPRcHEcIGMJR6zEgbxMMwVxBHsEAfCj+rWCZW8csmvxHlqJMr0/ny0xv1D0kJiYY YTCKB65e19QyDBWcggDHaiZJ/bHvwf+ZO9zcI6Du4h5yTfaR6CgOA8VqbptJ76V3GNu4vx UNypFiYlf8i1ZNxuDX8VzImka0m1F/rZTCX8wvIzSKq47O+M81VFmU911HpYUjN7xuP1V4 S9/iwTHBp9DiKFoDg3vp2ZsoYrgdP2yR3c7H0nXUA4ialuIREIjoqPej9kZR7Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776595354; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=fHjz2Ear2tFAA+clX0rA6fvQDkCU+KneWP4NUq7Ofl4=; b=G4r5EqV6IlGvmJWR4PNDd//Q0e7T1Zfng8pd80hSwS1Ojlzffnas8p0UH5aGlDRzo/WgG7 OOH47xTSqbfE11h3q/0gYZCBO3WnO/I4rn9NUSRHlTTddECG1TNBuzYuonI+PQPG9+4eq0 POtMY+v0N59aQMSSWdEJViO/0MEGytk6HFTmViGv92dYUpR1FoA+SwzzPb+nZSco51/Bqk /+1+HFOlYTlxqnM0DQQ8LPzP0su0o2x3DJxFI+tb3gj7AafiTNM4TRG/xCeMxypbPWWqtV dcEQk4sfRdsPPdc7A/A5abWzhpUu9U8vfbNAj/wO0f8npsWR5d+HU1FEGF2Ziw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fz4vG0lB7z1Lfh for ; Sun, 19 Apr 2026 10:42:34 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32df3 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sun, 19 Apr 2026 10:42:29 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Yuichiro NAITO From: Kevin Bowling Subject: git: ead225cd3346 - stable/13 - ixgbe: Fix MRQC register value. List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kbowling X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: ead225cd33461e5c0f126de43b2c7214ba132c66 Auto-Submitted: auto-generated Date: Sun, 19 Apr 2026 10:42:29 +0000 Message-Id: <69e4b195.32df3.198ebbde@gitrepo.freebsd.org> The branch stable/13 has been updated by kbowling: URL: https://cgit.FreeBSD.org/src/commit/?id=ead225cd33461e5c0f126de43b2c7214ba132c66 commit ead225cd33461e5c0f126de43b2c7214ba132c66 Author: Yuichiro NAITO AuthorDate: 2026-04-07 15:25:09 +0000 Commit: Kevin Bowling CommitDate: 2026-04-19 10:42:17 +0000 ixgbe: Fix MRQC register value. Focus on the MRQE field of the MRQC register, which is 4 bits wide, and we use these 3 types of values. - IXGBE_MRQC_RSSEN 0x1 (non VF mode) - IXGBE_MRQC_VMDQRSS32EN 0xA (less than 33 VFs) - IXGBE_MRQC_VMDQRSS64EN 0xB (less than 65 VFs) If we always take a bitwise OR with IXGBE_MRQC_RSSEN, IXGBE_MRQC_VMDQRSS32EN will never be chosen. Select these 3 types of values for the proper case. Signed-off-by: Yuichiro NAITO Pull Request: https://github.com/freebsd/freebsd-src/pull/2132 (cherry picked from commit 938c076b9b0bc458a3877b52535527d37199fc09) --- sys/dev/ixgbe/if_ix.c | 4 ++-- sys/dev/ixgbe/if_sriov.c | 2 +- sys/dev/ixgbe/ixgbe_sriov.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sys/dev/ixgbe/if_ix.c b/sys/dev/ixgbe/if_ix.c index fb350302d0c3..55cfc1926b40 100644 --- a/sys/dev/ixgbe/if_ix.c +++ b/sys/dev/ixgbe/if_ix.c @@ -682,7 +682,7 @@ ixgbe_initialize_rss_mapping(struct ixgbe_softc *sc) RSS_HASHTYPE_RSS_TCP_IPV6_EX; } - mrqc = IXGBE_MRQC_RSSEN; + mrqc = ixgbe_get_mrqc(sc->iov_mode); if (rss_hash_config & RSS_HASHTYPE_RSS_IPV4) mrqc |= IXGBE_MRQC_RSS_FIELD_IPV4; if (rss_hash_config & RSS_HASHTYPE_RSS_TCP_IPV4) @@ -701,7 +701,7 @@ ixgbe_initialize_rss_mapping(struct ixgbe_softc *sc) mrqc |= IXGBE_MRQC_RSS_FIELD_IPV6_UDP; if (rss_hash_config & RSS_HASHTYPE_RSS_UDP_IPV6_EX) mrqc |= IXGBE_MRQC_RSS_FIELD_IPV6_EX_UDP; - mrqc |= ixgbe_get_mrqc(sc->iov_mode); + IXGBE_WRITE_REG(hw, IXGBE_MRQC, mrqc); } /* ixgbe_initialize_rss_mapping */ diff --git a/sys/dev/ixgbe/if_sriov.c b/sys/dev/ixgbe/if_sriov.c index 9a907a82b9a1..f0dd29348e54 100644 --- a/sys/dev/ixgbe/if_sriov.c +++ b/sys/dev/ixgbe/if_sriov.c @@ -170,7 +170,7 @@ ixgbe_get_mrqc(int iov_mode) mrqc = IXGBE_MRQC_VMDQRSS32EN; break; case IXGBE_NO_VM: - mrqc = 0; + mrqc = IXGBE_MRQC_RSSEN; break; default: panic("Unexpected SR-IOV mode %d", iov_mode); diff --git a/sys/dev/ixgbe/ixgbe_sriov.h b/sys/dev/ixgbe/ixgbe_sriov.h index e5a78a7220cc..3c456ee819f2 100644 --- a/sys/dev/ixgbe/ixgbe_sriov.h +++ b/sys/dev/ixgbe/ixgbe_sriov.h @@ -94,7 +94,7 @@ u32 ixgbe_get_mrqc(int); #define ixgbe_align_all_queue_indices(_a) #define ixgbe_vf_que_index(_a, _b, _c) (_c) #define ixgbe_get_mtqc(_a) IXGBE_MTQC_64Q_1PB -#define ixgbe_get_mrqc(_a) 0 +#define ixgbe_get_mrqc(_a) IXGBE_MRQC_RSSEN #endif /* PCI_IOV */