From owner-freebsd-current Tue Dec 2 13:04:48 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id NAA03599 for current-outgoing; Tue, 2 Dec 1997 13:04:48 -0800 (PST) (envelope-from owner-freebsd-current) Received: from alpo.whistle.com (alpo.whistle.com [207.76.204.38]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id NAA03591 for ; Tue, 2 Dec 1997 13:04:43 -0800 (PST) (envelope-from julian@whistle.com) Received: (from daemon@localhost) by alpo.whistle.com (8.8.5/8.8.5) id MAA18161; Tue, 2 Dec 1997 12:59:18 -0800 (PST) Received: from UNKNOWN(), claiming to be "current1.whistle.com" via SMTP by alpo.whistle.com, id smtpd018156; Tue Dec 2 12:59:10 1997 Message-ID: <34847612.446B9B3D@whistle.com> Date: Tue, 02 Dec 1997 12:56:50 -0800 From: Julian Elischer Organization: Whistle Communications X-Mailer: Mozilla 3.0Gold (X11; I; FreeBSD 2.2-CURRENT i386) MIME-Version: 1.0 To: Poul-Henning Kamp CC: current@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_aio.c References: <2923.881086024@critter.freebsd.dk> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk Poul-Henning Kamp wrote: > > >>And yes, the reason is performance. > > > >Then you should back the changes out IMMEDIATELY, as > > > > *retval = 10; > > > >is exactly the same speed as: > > > > p->p_retval[0] = 10; > > BZZZTT! Wrong answer. > > We save the time it takes to push the &retval on the stack on ALL syscalls. Ok, ok, why don't you writ ea 2 paragraph description of the change.. before amd after.. and say why you think it is a win. address compatibilty for people who have kernel modules for bot NetBSD and FreeBSD (e.g. the ipfilter stuff) we do the following: have a quick discussion about the pro's and cons. and get David to vote.. after all that's why we voted him to be "Chief architect" remember? I know Sean will feel a lot better if he knows it's had a bit more ratification.. Poul. Can you think > > -- > Poul-Henning Kamp FreeBSD coreteam member > phk@FreeBSD.ORG "Real hackers run -current on their laptop."