From nobody Thu Jul 17 16:01:51 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bjd34083Zz61wfr; Thu, 17 Jul 2025 16:01:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bjd333SlCz3d78; Thu, 17 Jul 2025 16:01:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752768111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6RcydlyMVCfjIzLU0Vyi91fXKRBg3xYeeBH/6NQzysQ=; b=tAG6rjT1/PzuXqD124WcCGILOJsepVZEDjsCbrVURPdyoNHYnn/7JTCYjX5ZrpASjXZ0X5 sGBWgAJPtjBLPq5xCXOe9eHQo+kyLaAzZE9Niw9l1rHCVlyIE3JC1TBkhnVgInaQJkmwlu QZZt2OysylxATNvkKyP/NvUktLNyA9nNSfHJ7jt0pAqvCoKvSc/EpoXzSS1e7Tv62mDSKS 77Xm7IxI0vLCVgBdC15xrr/xEhXiloH+ownMHf/Jb/QASTZa2kYPvc3v31uwJ2TpilbX2P B9XhQ7aKy2z0oj7Mq8uNSrk3wJq4oaXMAdzWUd/M4FHJkHnnG75eodYPRUFt7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1752768111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6RcydlyMVCfjIzLU0Vyi91fXKRBg3xYeeBH/6NQzysQ=; b=Dl6ouJ3Rmn/hHSvao0cTb4bbkwUkKfFtjXdQSPB9fovOg1fw2dbq3ULSnaoCIuA9UAVaXr QWwfnWUPg+3p4hc0+mUn9Vp0IWLBxGs7crx/pLTGqyPzO78eukI36M6X4qpGhIIJQjm+sN DE9LjZiBmB0xfOSvdeM/ObxNrAS1kWyBnrhfWXOejlecCOKb/jeHrurm22sa5uUN3P0CQD OvEta0GpgL8abmaUFACdZMu0J+Xs39BENZJh2mC08Wzd7p/zTI9Vw8UFa6Cw5wMfgAs6tO wpaZBf2Q9o7/hBHp94nnsC0n3mkd8VS9CDrUVwFkAmoQNCiZLqVIY56lufwO3g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1752768111; a=rsa-sha256; cv=none; b=omX3iL4FeEKdHkaTfkqld930BkfjWb97TX0uzWc9toqEbaqz4gt7Xr2fy1lsWAb0O4/p26 uqTHl2ylIUviFg3AccKche0doqr6Rry6/XwJZqw1V2nIKDfmCf7ZTzKR4BSCxXAKYbV/DD nf3HM3uZbUv7KsxBOUndWtvP2BRW47DCtKea0LT3v1kkZ/bT79lx6GHRy6qkzo7ACD1zej 4DkMvWRveVrLP4BW45QFnFrJn318sYX52/DywVawT33mbpcg8K43zJyv36VIkA27rFyoWz pMPu2HTuEz1+5Kg616b8ddzWzXUwpzd/UK+YqAEsX1ph9PLGhsQ/WQDyW8p1Kg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bjd332jrHz12C0; Thu, 17 Jul 2025 16:01:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56HG1p2u032916; Thu, 17 Jul 2025 16:01:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56HG1pXt032913; Thu, 17 Jul 2025 16:01:51 GMT (envelope-from git) Date: Thu, 17 Jul 2025 16:01:51 GMT Message-Id: <202507171601.56HG1pXt032913@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 2181568715e8 - main - libbegemot: improve tracing prints List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2181568715e87f2ee434ba9c484dac43f19667ba Auto-Submitted: auto-generated The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=2181568715e87f2ee434ba9c484dac43f19667ba commit 2181568715e87f2ee434ba9c484dac43f19667ba Author: Gleb Smirnoff AuthorDate: 2025-07-17 16:01:09 +0000 Commit: Gleb Smirnoff CommitDate: 2025-07-17 16:01:30 +0000 libbegemot: improve tracing prints Add newlines. Use __func__ instead of hardcoded name (fixes one case). While here, wrap lines according to style(9). Differential Revision: https://reviews.freebsd.org/D51357 --- contrib/libbegemot/rpoll.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/contrib/libbegemot/rpoll.c b/contrib/libbegemot/rpoll.c index c61b84057eba..f5ce43140205 100644 --- a/contrib/libbegemot/rpoll.c +++ b/contrib/libbegemot/rpoll.c @@ -285,8 +285,8 @@ poll_register(int fd, poll_f func, void *arg, int mask) poll_unblocksig(); if(rpoll_trace) - fprintf(stderr, "poll_register(%d, %p, %p, %#x)->%tu", - fd, (void *)func, (void *)arg, mask, p - regs); + fprintf(stderr, "%s(%d, %p, %p, %#x)->%tu\n", __func__, fd, + (void *)func, (void *)arg, mask, p - regs); return p - regs; } @@ -297,7 +297,7 @@ void poll_unregister(int handle) { if(rpoll_trace) - fprintf(stderr, "poll_unregister(%d)", handle); + fprintf(stderr, "%s(%d)\n", __func__, handle); poll_blocksig(); @@ -399,8 +399,8 @@ poll_start_utimer(unsigned long long usecs, int repeat, timer_f func, void *arg) resort = 1; if(rpoll_trace) - fprintf(stderr, "poll_start_utimer(%llu, %d, %p, %p)->%tu", - usecs, repeat, (void *)func, (void *)arg, p - tims); + fprintf(stderr, "%s(%llu, %d, %p, %p)->%tu\n", __func__, usecs, + repeat, (void *)func, (void *)arg, p - tims); return p - tims; } @@ -418,7 +418,7 @@ poll_stop_timer(int handle) u_int i; if(rpoll_trace) - fprintf(stderr, "poll_stop_timer(%d)", handle); + fprintf(stderr, "%s(%d)\n", __func__, handle); tims[handle].func = NULL; tims_used--; @@ -597,9 +597,10 @@ poll_dispatch(int wait) if(mask) { if(rpoll_trace) - fprintf(stderr, "poll_dispatch() -- " - "file %d/%d %x", - regs[idx].fd, idx, mask); + fprintf(stderr, + "%s() -- file %d/%d %x\n", + __func__, regs[idx].fd, + idx, mask); (*regs[idx].func)(regs[idx].fd, mask, regs[idx].arg); } } @@ -617,7 +618,8 @@ poll_dispatch(int wait) if(tims[tfd[i]].when > now) break; if(rpoll_trace) - fprintf(stderr, "rpoll_dispatch() -- timeout %d",tfd[i]); + fprintf(stderr, "%s() -- timeout %d\n", + __func__, tfd[i]); (*tims[tfd[i]].func)(tfd[i], tims[tfd[i]].arg); if(tfd[i] < 0) continue;