Date: Mon, 18 Oct 1999 11:25:02 -0700 (PDT) From: Matthew Dillon <dillon@apollo.backplane.com> To: Poul-Henning Kamp <phk@FreeBSD.org> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: You gotta be kidding .... Re: cvs commit: src/sys/miscfs/specfs spec_vnops.c Message-ID: <199910181825.LAA69079@apollo.backplane.com> References: <199910181659.JAA86963@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an inappropriate commit which has been well-discussed
several times now. I don't understand why you continue to push
forward in this direction when several people, including me,
believe strongly that it is not appropriate to fold block dev
operation into char dev operation due to major differences between
the way block devices and char devices work.
Instead, the appropriate way is to turn off user level blockdev
access entirely. This is the conclusion that was made weeks ago
when you first started your rampage to blow away block devices. A
time table was also proposed at that time and I committed a sysctl
to implement it (which you attempted to remove two weeks ago, which
led to blowup #2).
Please back-out this commit. If you really want to go forward, you
can propose to change the default for block device access (i.e. disable
it entirely). Folding block devices into char devices is not the
correct solution. You can also propose your solution, but simply
committing it just isn't right. You are making no attempt to work with
the group and, indeed, essentially informing everyone that you have
no intention to work with the group by doing this.
And, I will add again that you have made yet another commmit in an
area for which an obvious conflict of interest exists without bothering
to have your work reviewed or even discussed.
-Matt
Matthew Dillon
<dillon@backplane.com>
:
:phk 1999/10/18 09:59:51 PDT
:
: Modified files:
: sys/miscfs/specfs spec_vnops.c
: Log:
: Change the default for the vfs.bdev_buffered sysctl to zero.
:
: This means that access to block devices nodes will act the
: same as char device nodes for disk-like devices.
:
: If you encounter problems after this, where programs accessing
: disks directly fail to operate, please use the following command
: to revert to previous behaviour:
:
: sysctl -w vfs.bdev_buffered=1
:
: And verify that this was indeed the cause of your trouble.
:
: See the mail-archives of the arch@FreeBSD.org list for background.
:
: Revision Changes Path
: 1.120 +2 -2 src/sys/miscfs/specfs/spec_vnops.c
:
:
:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199910181825.LAA69079>