From owner-freebsd-current Fri Jan 21 16:27:21 2000 Delivered-To: freebsd-current@freebsd.org Received: from canonware.com (canonware.com [207.20.242.18]) by hub.freebsd.org (Postfix) with SMTP id 814B415620 for ; Fri, 21 Jan 2000 16:27:19 -0800 (PST) (envelope-from jasone@canonware.com) Received: (qmail 51822 invoked by uid 1001); 22 Jan 2000 00:25:41 -0000 Date: Fri, 21 Jan 2000 16:25:41 -0800 From: Jason Evans To: David O'Brien Cc: current@freebsd.org Subject: Re: even more breakage in current Message-ID: <20000121162540.E27689@sturm.canonware.com> References: <20000121101157.A18956@dub.net> <20000121142251.D27689@sturm.canonware.com> <20000121154727.C43755@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: <20000121154727.C43755@dragon.nuxi.com>; from obrien@freebsd.org on Fri, Jan 21, 2000 at 03:47:27PM -0800 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Fri, Jan 21, 2000 at 03:47:27PM -0800, David O'Brien wrote: > On Fri, Jan 21, 2000 at 02:22:51PM -0800, Jason Evans wrote: > > > > I did a 'make includes' during my testing, so I didn't have this > > problem. > ... > > > > In any case, doing a 'make includes' will get you past this. > > But this is not a very satisfiable bootstrap requirement. > We need to keep in mind that that > cd /usr/src > cvs up > make world > > is how it is done. If things wont build, then a solution w/in the > "world" Makefiles need to be found. I often do a 'make includes' to be able to iteratively test changes. Once I'm happy that the changes are sound, there is no way to assure that the changes didn't cause a bootstrapping problem like this one. This is the second time that this has been a problem for me. The first time I caught it and put a hack in the libc_r Makefile: CFLAGS+=-I${.CURDIR}/../../include Marcel said that this is not appropriate for reasons I didn't understand. If this isn't appropriate, and the build system is structured such that it pulls definitions from the installed headers, then what *is* the correct solution? I enjoy breaking the world even less than people enjoy dealing with my breakage. I generally do a 'make world' before checking in non-trivial changes (and did so in this case), but obviously, that doesn't catch this kind of problem. Jason To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message