Date: Wed, 6 Dec 2017 16:50:19 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... Message-ID: <b3184c72-7381-0c73-813c-f6a23f0fddd1@FreeBSD.org> In-Reply-To: <8e2fd368-ad3e-27bb-0834-4b6f2f99e905@FreeBSD.org> References: <201711241450.vAOEoSFW056744@repo.freebsd.org> <ea6c8eb5-f849-df2a-ab80-75d8ebc1edb8@FreeBSD.org> <0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org> <cec48299-e075-fe51-1297-4eb10a4f7619@FreeBSD.org> <8e2fd368-ad3e-27bb-0834-4b6f2f99e905@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N7qFonVXa2aX9q0lSbr4edMau1wcRpcxQ Content-Type: multipart/mixed; boundary="ItijETbQp6HRpNjgeh6DvPB0f26c8E2md"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Hans Petter Selasky <hps@selasky.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <b3184c72-7381-0c73-813c-f6a23f0fddd1@FreeBSD.org> Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... References: <201711241450.vAOEoSFW056744@repo.freebsd.org> <ea6c8eb5-f849-df2a-ab80-75d8ebc1edb8@FreeBSD.org> <0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org> <cec48299-e075-fe51-1297-4eb10a4f7619@FreeBSD.org> <8e2fd368-ad3e-27bb-0834-4b6f2f99e905@FreeBSD.org> In-Reply-To: <8e2fd368-ad3e-27bb-0834-4b6f2f99e905@FreeBSD.org> --ItijETbQp6HRpNjgeh6DvPB0f26c8E2md Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 12/6/2017 4:48 PM, Bryan Drewery wrote: > On 12/6/2017 4:38 PM, Bryan Drewery wrote: >> On 12/6/2017 4:28 PM, Hans Petter Selasky wrote: >>> On 12/07/17 01:10, Bryan Drewery wrote: >>>> I'm a bit speechless.=C2=A0 Why??=C2=A0 The old version was 90% fine= and I sent >>>> you advice on how to make it work with the new layout. >>> >>> Hi, >>> >>> I tried to listen to your advice, splitting up the Makefiles, not >>> listing every dependency. Further how the OFED libraries are linked h= as >>> changed. Two iterations for building the OFED libraries is not enough= , >>> like before. We really need four iterations. >>> >>> I don't see how the current approach is "wrong". Can you explain a bi= t >>> more? >> >> 1. SUBDIR=3D../../somewhere else is inherently wrong. >> 2. Building a library from a directory named '2' is wrong. >> 3. Not just using proper SUBDIR_DEPEND and making all these subdirs is= >> not needed and complicates things MORE by splitting them all up. >> 4. Building a library from a directory where its real bsd.lib.mk is no= t >> at is wrong. >> 5. Depending on an include directory in the Makefile.inc1 library >> dependencies is simply not needed - I told you that. >> 6. Using these /0 /1 /2 /3 directories actually hurts the 'make >> libraries' parallelism/dependency graph. It ends up building /1 rather= >> than building libibcm and libibumad directly in its graph. It creates= >> an indirection which adds more unneeded submake recursion. >> >> The whole thing needlessly obfuscates these libraries. >> >> It's fine, I'm going to rewrite it all now. >> >=20 > 7. We don't put FreeBSD Makefiles in the same directory as contributed > files. It's against the pattern. So moving contrib/ofed/usr.lib/* to > contrib/ofed/*/ is wrong. It complicates future merges of contrib code.= > Really none of these Makefiles should be in contrib/ofed - the proper > thing would be to move them out, not to inline them with the contribute= d > code. >=20 8. And you blew away my Makefile.depend files, which I do normally say I'll deal with, but a far simpler directory structure movement would have easily kept them and I could have updated them. But now there's not even something to start from since they were deleted for no reason. --=20 Regards, Bryan Drewery --ItijETbQp6HRpNjgeh6DvPB0f26c8E2md-- --N7qFonVXa2aX9q0lSbr4edMau1wcRpcxQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJaKJBLAAoJEDXXcbtuRpfPhrMH+gPxofqjUZb+I+W9LTuB2ewZ 6Sf0G2/0n7yIk2LXHMnCRIL1S7I9RR+perSrO2xhCvreC8xpRhjkdxlErYfYS0tp rz65+ZSk2p7nOnVn3sBllLkTQAhyVA/AocaeBBAPRYzHeBTYytBWsrSwegPabbVn LjeR6Nht7jGdZ1F1CfxAtScxX4bF17wXgxt2i4tqzS78zi9VR9oZXYcloCdLOlP7 O5IjFpkVeOn9yKWWd88VaxsUEqVmLigoKVMLDPcVrKrnd2BtfUOHsTLi+ZoUA+16 Ac2NK8Hw39B0AIhIY+h236ro7mO/GiyuhDYIz7f2TcdZ+S+2BN9CyDZTZmbA1MU= =i5Op -----END PGP SIGNATURE----- --N7qFonVXa2aX9q0lSbr4edMau1wcRpcxQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b3184c72-7381-0c73-813c-f6a23f0fddd1>