From owner-svn-src-all@freebsd.org Wed Mar 16 18:45:52 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49DA4AD3404; Wed, 16 Mar 2016 18:45:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BFF8B904; Wed, 16 Mar 2016 18:45:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id u2GIjjI4025641 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Wed, 16 Mar 2016 20:45:45 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua u2GIjjI4025641 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id u2GIjjAT025639; Wed, 16 Mar 2016 20:45:45 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 16 Mar 2016 20:45:45 +0200 From: Konstantin Belousov To: Bryan Drewery Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r296947 - head/share/man/man9 Message-ID: <20160316184545.GN1741@kib.kiev.ua> References: <201603161839.u2GIdm5C072960@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201603161839.u2GIdm5C072960@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2016 18:45:52 -0000 On Wed, Mar 16, 2016 at 06:39:48PM +0000, Bryan Drewery wrote: > Author: bdrewery > Date: Wed Mar 16 18:39:48 2016 > New Revision: 296947 > URL: https://svnweb.freebsd.org/changeset/base/296947 > > Log: > Remove incorrect BUGS entry about asserting lock not held. > > For non-WITNESS< assertion support for SA_UNLOCKED was added in r125421 and > made to panic in r126316. > > MFC after: 1 week > > Modified: > head/share/man/man9/sx.9 > > Modified: head/share/man/man9/sx.9 > ============================================================================== > --- head/share/man/man9/sx.9 Wed Mar 16 17:35:55 2016 (r296946) > +++ head/share/man/man9/sx.9 Wed Mar 16 18:39:48 2016 (r296947) > @@ -26,7 +26,7 @@ > .\" > .\" $FreeBSD$ > .\" > -.Dd March 13, 2016 > +.Dd March 16, 2016 > .Dt SX 9 > .Os > .Sh NAME > @@ -320,11 +320,6 @@ end up sleeping while holding a mutex, w > .Xr rwlock 9 , > .Xr sema 9 > .Sh BUGS > -Currently there is no way to assert that a lock is not held. > -This is not possible in the > -.No non- Ns Dv WITNESS > -case for asserting that this thread > -does not hold a shared lock. > In the > .No non- Ns Dv WITNESS > case, the The removed text was not quite correct, but its removal is not quite correct either. sx (and rw) locks do not track shared owners, so in non-witness case only exclusive ownership by curthread triggers panic for SA_UNLOCKED case. Shared ownership is silently ignored by the assert.