From owner-svn-src-head@freebsd.org Fri Oct 14 18:25:56 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 22B8FC1216F for ; Fri, 14 Oct 2016 18:25:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DB4A9D81 for ; Fri, 14 Oct 2016 18:25:55 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x236.google.com with SMTP id i202so129306687ioi.2 for ; Fri, 14 Oct 2016 11:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=GZTgEuTVhz29Xz4tjYWUnaBXd62F5LPZdmqJUFRB7oM=; b=DORQZd1zek3nKszWWMWVfuD2sQrT9vgCcSySLsRtto4OJZbuO+50HiV/FLMb0Ec72C mAZfAdleP4lVuZA29kOA/VSDrp4Y91iY8pRZj0l2TiczinuP3kLraxQiftapHhYubMf9 CdG920SaIsa0v6rjkvjpA2J2AVaIurgCIz8X0GrgbvI67yrATCA3FUcJfDCjfeF9ik/L dJBUYY/DB0iPRQX0x/W2sWOV1m8J0z8jCepLR8/2YiMZXWJz3qD9lXeCouSFxeX9UtT+ xfaM3HLKQJyyODkEA12I4QE6eqiBd/s3GKAwebDYmyIVCC/2GjYSiZxSKY72chDX1Uhu MdKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=GZTgEuTVhz29Xz4tjYWUnaBXd62F5LPZdmqJUFRB7oM=; b=VUHCWW7aNfxDT468XmyLxyzU5s+yP6vtWxXe70Mh4bE4AqgJg2VSO8CTm9klyEywi0 e8jVVtFOWzI91uYjjuLX/MaaUOV0L8lFE0UljzNpi/ZZAa2e8kkPpjf0R0gg8sjgSoA6 NNaSlZU3KSEWiV6cqNhgHPOAcrAb0ABFfi69FJOebOtnL9iNVLU5uzz1dnRBkyc+nuVo +9ufOtT+/mrsQT/At+Quxal7JJFd+H+E9aSX698slYvnBjO7zFuNmeMiEMvC+ZdNWaWL AHmYkHofbj/wMgNduhCqVfGXHgUr9P03b6c2xbJbZZwNztfzPxtnpEXOqBK8du4kUaDA k9Ww== X-Gm-Message-State: AA6/9RkPIsjnRKh2VhFAtREWEjNpCVTwDoOCqPiGGm7S+LTv22jBm8REFsNhPPSs+de4G2X6R7Lq60f6uh8UBw== X-Received: by 10.107.139.79 with SMTP id n76mr14626164iod.166.1476469555278; Fri, 14 Oct 2016 11:25:55 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.77.85 with HTTP; Fri, 14 Oct 2016 11:25:54 -0700 (PDT) X-Originating-IP: [2607:fb90:6c81:f6a1:0:22:e381:4d01] Received: by 10.79.77.85 with HTTP; Fri, 14 Oct 2016 11:25:54 -0700 (PDT) In-Reply-To: <20161014175542.GB65545@ambrisko.com> References: <201610141710.u9EHArlL089412@repo.freebsd.org> <20161014172705.GA65545@ambrisko.com> <3FF8A9D8-0C8A-4033-A7FC-8B64E9AB025F@panasas.com> <20161014175542.GB65545@ambrisko.com> From: Warner Losh Date: Fri, 14 Oct 2016 12:25:54 -0600 X-Google-Sender-Auth: V9n-d-WeNwgst20it5x-x-KCAy4 Message-ID: Subject: Re: svn commit: r307326 - head/sys/boot/efi/loader To: Doug Ambrisko Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Doug Ambrisko , Ravi Pokala Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 18:25:56 -0000 On Oct 14, 2016 11:55 AM, "Doug Ambrisko" wrote: > > On Fri, Oct 14, 2016 at 10:33:15AM -0700, Ravi Pokala wrote: > | -----Original Message----- > | > From: on behalf of Doug Ambrisko < ambrisko@ambrisko.com> > | > Date: 2016-10-14, Friday at 10:27 > | > To: Warner Losh > | > Cc: Doug Ambrisko , src-committers < src-committers@freebsd.org>, "svn-src-all@freebsd.org" < svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" < svn-src-head@freebsd.org> > | > Subject: Re: svn commit: r307326 - head/sys/boot/efi/loader > | > > | > On Fri, Oct 14, 2016 at 11:16:02AM -0600, Warner Losh wrote: > | > | Love the functionality, but don't like using the 'hint' namespace for > | > | this. Can we change it now before too many things depend on it? We had > | > | similar issues in ACPI and moved it to the 'acpi' space. Can we move > | > | this to the 'smbios' space please? > | > | > | > | The reason is that 'hint' is special and sometimes filtered out, so it > | > | is a poor choice to export data from the boot loader to the kernel. > | > > | > The reason I picked hint was it could be put /boot/device.hints > | > to make it work as well and that it was a hint. Other standards in the > | > future might use other methods. Looking back over the email I had > | > with John he had suggested hint.smbios.0.anchor to make this look > | > different. This code had been hanging around for so long I forgot > | > about that and we were using hint.smbios.0.mem in our shipping code base. > | > > | > However, I hope that nothing would use this except for smbios(4) and > | > for people to make smbios(4) useful for this info. > | > | Doug's looking at me when he says that. :-) > | > | We talked about this last night at BAFUG; right now, even if smbios(4) > | is able to find the SMBIOS info -- it currently only looks at the > | aforementioned 0xf0000 - 0xfffff range, so it can't find it on UEFI -- > | smbios(4) doesn't actually provide any interface for that information. > | Doug and I have talked about making smbios(4) useful, by parsing the > | data and providing KPIs and APIs, for years now; I think I'll *finally* > | have the time and motivation to do so "soon". > > I've actually talked to a few people. However, your the first to > step up. This needs to be designed and will take some time and > review. I would hope that except for smbios(4), nothing else would > use this kenv but there is nothing to prevent that :-( I could name > it super_secret_dont_use. > > BTW, to get you started this patch prevents smbios(4) from blowing chunks > when it gets a anchor in high memory and works on legacy machines. > > --- /sys/x86/bios/smbios.c 2013-10-01 14:28:25.000000000 -0700 > +++ ./smbios.c 2016-04-11 11:58:03.234969000 -0700 > @@ -38,6 +38,7 @@ __FBSDID("$FreeBSD: release/9.2.0/sys/x8 > #include > #include > #include > +#include > > #include > #include > @@ -59,7 +60,7 @@ struct smbios_softc { > }; > > #define RES2EPS(res) ((struct smbios_eps *)rman_get_virtual(res)) > -#define ADDR2EPS(addr) ((struct smbios_eps *)BIOS_PADDRTOVADDR(addr)) > +#define ADDR2EPS(addr) ((struct smbios_eps *)PHYS_TO_DMAP(addr)) > > static devclass_t smbios_devclass; > > @@ -71,19 +72,26 @@ static int smbios_modevent (module_t, in > > static int smbios_cksum (struct smbios_eps *); > > +static unsigned long addr; > +static SYSCTL_NODE(_hw, OID_AUTO, smbios, CTLFLAG_RD, 0, > + "SMBIOS driver parameters"); > +SYSCTL_LONG(_hw_smbios, OID_AUTO, mem, CTLFLAG_RW, > + &addr, 0, ""); > + > static void > smbios_identify (driver_t *driver, device_t parent) > { > device_t child; > - u_int32_t addr; > int length; > int rid; > > if (!device_is_alive(parent)) > return; > > - addr = bios_sigsearch(SMBIOS_START, SMBIOS_SIG, SMBIOS_LEN, > - SMBIOS_STEP, SMBIOS_OFF); > + if (resource_long_value("smbios", 0, "mem", &addr) != 0 || > + addr == 0) > + addr = bios_sigsearch(SMBIOS_START, SMBIOS_SIG, SMBIOS_LEN, > + SMBIOS_STEP, SMBIOS_OFF); > if (addr != 0) { > rid = 0; > length = ADDR2EPS(addr)->length; > > Note I don't plan to commit this since it doesn't really do much and we > need a lot more. I was planning on exporting all smbios stuff via sysctl. You can still put non hints.* in device.hints too. I can rework things a bit to be more complete is you like... Warner