From owner-svn-src-head@FreeBSD.ORG Fri Feb 7 21:28:01 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ED8A1C03; Fri, 7 Feb 2014 21:28:01 +0000 (UTC) Received: from mail-wg0-x22e.google.com (mail-wg0-x22e.google.com [IPv6:2a00:1450:400c:c00::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 147F21AC5; Fri, 7 Feb 2014 21:28:00 +0000 (UTC) Received: by mail-wg0-f46.google.com with SMTP id x12so2624267wgg.13 for ; Fri, 07 Feb 2014 13:27:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=R3iUhP7mS/n+21d8OF+3ZrmSsLlE1kkrdjZeHUneNPQ=; b=Xo5aNEpe2L7jRj7DZAiPbL1Y38v+byXbASrujvstcpygsjTdZxBQX3rKD1gNedGbMw XVSykt1Au0dgC+tjkGqtfbDav7k62JxhXu9Z4WjIu7FFDKbqjTw8km6JK2YRrShJ9doZ wkjdlgpnS/kRu9hSd19vEu1gHZus+2djowpa3zVgKuBu/vm51G8+IQJ2uytSINS6rcl9 Bp2BmsG8ikGoHj8q2wMZc5718zF8ugLQ2a/ICfnTJR5ynJFxyU+tqOyg2OoN8KMAx6zS /N1ksequruBJPKve6ec16zxa3Mloqqaa3IQezw/anfvtXyS6xBSSammI9puzsX4FWpZt UqXQ== MIME-Version: 1.0 X-Received: by 10.194.110.41 with SMTP id hx9mr12617981wjb.28.1391808478906; Fri, 07 Feb 2014 13:27:58 -0800 (PST) Sender: edschouten@gmail.com Received: by 10.194.177.169 with HTTP; Fri, 7 Feb 2014 13:27:58 -0800 (PST) In-Reply-To: <20140207171025.d33b95770f6b0d7d00b4aab3@freebsd.org> References: <201402071239.s17CdwIH007683@svn.freebsd.org> <20140207171025.d33b95770f6b0d7d00b4aab3@freebsd.org> Date: Fri, 7 Feb 2014 22:27:58 +0100 X-Google-Sender-Auth: PzNFTJ3H8taeKQ9cQmzyPXMWVG4 Message-ID: Subject: Re: svn commit: r261585 - head/sys/dev/vt/hw/vga From: Ed Schouten To: Aleksandr Rybalko Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Feb 2014 21:28:02 -0000 Hi Aleksandr, On 7 February 2014 16:10, Aleksandr Rybalko wrote: > On Fri, 7 Feb 2014 15:04:47 +0100 > Ed Schouten wrote: >> On 7 February 2014 13:39, Aleksandr Rybalko wrote: > Also people asking me about advanced features of vt(9), like use > multiple displays. I'm not sure, but signed coordinates may help with > some things on that way (or makes more problems :) ). But if you were to have multiple displays, you should have separate coordinate systems per display. It should not be seen as a single pane. >> Furthermore, I think it's a bit weird that vga_bitbltchr() contains >> explicit bounds checking. What happened there? I remember at one point >> in time, we had the nice invariant that vt(9) never attempted to draw >> outside of the display resolution. What caused us to give up on that? > > Mouse cursor allowed to partially go out of screen, so we have to check > (or use special function for mouse cursor). Well, that's a compelling argument. Still, it's a bit weird then that the bitblt function itself does not take signed coordinates. Would it make sense to bring that in sync then? -- Ed Schouten