From owner-cvs-all@FreeBSD.ORG  Tue May  6 14:00:38 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CC45C37B401; Tue,  6 May 2003 14:00:38 -0700 (PDT)
Received: from khavrinen.lcs.mit.edu (khavrinen.lcs.mit.edu [18.24.4.193])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D722543F75; Tue,  6 May 2003 14:00:37 -0700 (PDT)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: from khavrinen.lcs.mit.edu (localhost [IPv6:::1])
	by khavrinen.lcs.mit.edu (8.12.9/8.12.9) with ESMTP id h46L0aVo065875
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);
	Tue, 6 May 2003 17:00:36 -0400 (EDT)
	(envelope-from wollman@khavrinen.lcs.mit.edu)
Received: (from wollman@localhost)
	by khavrinen.lcs.mit.edu (8.12.9/8.12.9/Submit) id h46L0a1Z065872;
	Tue, 6 May 2003 17:00:36 -0400 (EDT)
	(envelope-from wollman)
Date: Tue, 6 May 2003 17:00:36 -0400 (EDT)
From: Garrett Wollman <wollman@lcs.mit.edu>
Message-Id: <200305062100.h46L0a1Z065872@khavrinen.lcs.mit.edu>
To: Nate Lawson <nate@root.org>
In-Reply-To: <20030506133223.V29676@root.org>
References: <20030506020032.8318437B478@hub.freebsd.org>
	<20030506133223.V29676@root.org>
X-Spam-Score: -19.8 ()
	IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES
X-Scanned-By: MIMEDefang 2.33 (www . roaringpenguin . com / mimedefang)
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/pci if_sis.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 May 2003 21:00:39 -0000

<<On Tue, 6 May 2003 13:57:47 -0700 (PDT), Nate Lawson <nate@root.org> said:

> I would rather you deleted the first call to callout_handle_init() instead
> (after the "Inform the world" comment).  Reasons include poor style for
> the first one and uniformity with other sys/pci/if_* drivers which do the
> init right before ether_ifattach().

I would rather that drivers were fixed to use the new (FreeBSD 4)
callout API, so that we can eventually deprecate the old one.

-GAWollman