From owner-cvs-src@FreeBSD.ORG  Sun Mar 27 00:33:26 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9FF7016A4CE; Sun, 27 Mar 2005 00:33:26 +0000 (GMT)
Received: from ebb.errno.com (ebb.errno.com [66.127.85.87])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 55E0043D3F; Sun, 27 Mar 2005 00:33:26 +0000 (GMT)
	(envelope-from sam@errno.com)
Received: from [66.127.85.91] (sam@[66.127.85.91])
	(authenticated bits=0)
	by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j2R0XHms069665
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 26 Mar 2005 16:33:22 -0800 (PST)
	(envelope-from sam@errno.com)
Message-ID: <4245FFD2.8030405@errno.com>
Date: Sat, 26 Mar 2005 16:35:30 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041208)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: src-committers@FreeBSD.org
References: <200503270029.j2R0TbO4093525@repoman.freebsd.org>
In-Reply-To: <200503270029.j2R0TbO4093525@repoman.freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/twa twa.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Mar 2005 00:33:26 -0000

Sam Leffler wrote:
> sam         2005-03-27 00:29:37 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/twa          twa.c 
>   Log:
>   check copyin+copyout return values when processing TWA_IOCTL_GET_LOCK
>   
>   Noticed by:     Coverity Prevent analysis tool

Note that several places in this routine copyin failures are ignored and 
user supplied data appears to be used w/o validation.  I'm not sure if 
these ioctls are accessible only to root but someone should cleanup this 
stuff.

	Sam