From owner-freebsd-bugs@FreeBSD.ORG Fri Jan 7 19:50:02 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A48A11065673 for ; Fri, 7 Jan 2011 19:50:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 828018FC12 for ; Fri, 7 Jan 2011 19:50:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p07Jo2Pv014508 for ; Fri, 7 Jan 2011 19:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p07Jo2gk014507; Fri, 7 Jan 2011 19:50:02 GMT (envelope-from gnats) Resent-Date: Fri, 7 Jan 2011 19:50:02 GMT Resent-Message-Id: <201101071950.p07Jo2gk014507@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andrew Boyer Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7C232106566B for ; Fri, 7 Jan 2011 19:40:46 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 6C06C8FC17 for ; Fri, 7 Jan 2011 19:40:46 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p07JeklW060922 for ; Fri, 7 Jan 2011 19:40:46 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p07JekOu060921; Fri, 7 Jan 2011 19:40:46 GMT (envelope-from nobody) Message-Id: <201101071940.p07JekOu060921@red.freebsd.org> Date: Fri, 7 Jan 2011 19:40:46 GMT From: Andrew Boyer To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/153772: [ixgbe] [patch] sysctls reference wrong XON/XOFF variables X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2011 19:50:02 -0000 >Number: 153772 >Category: kern >Synopsis: [ixgbe] [patch] sysctls reference wrong XON/XOFF variables >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jan 07 19:50:02 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Andrew Boyer >Release: -current >Organization: Avere Systems >Environment: N/A >Description: ixgbe.c creates sysctls called 'link_xon_rcvd' and 'link_xoff_rcvd', but they display the transmit statistics instead of the receive statistics. It's a copy-and-paste error. >How-To-Repeat: Found by inspection >Fix: Patch attached with submission follows: --- src/sys/dev/ixgbe/ixgbe.c 2011-01-07 14:29:37.000000000 -0500 +++ src/sys/dev/ixgbe/ixgbe.c 2011-01-07 14:29:17.000000000 -0500 @@ -5460,13 +5460,13 @@ CTLFLAG_RD, &stats->lxontxc, "Link XON Transmitted"); SYSCTL_ADD_QUAD(ctx, stat_list, OID_AUTO, "link_xon_rcvd", - CTLFLAG_RD, &stats->lxontxc, + CTLFLAG_RD, &stats->lxonrxc, "Link XON Received"); SYSCTL_ADD_QUAD(ctx, stat_list, OID_AUTO, "link_xoff_txd", CTLFLAG_RD, &stats->lxofftxc, "Link XOFF Transmitted"); SYSCTL_ADD_QUAD(ctx, stat_list, OID_AUTO, "link_xoff_rcvd", - CTLFLAG_RD, &stats->lxofftxc, + CTLFLAG_RD, &stats->lxoffrxc, "Link XOFF Received"); /* Packet Reception Stats */ >Release-Note: >Audit-Trail: >Unformatted: