From owner-cvs-all  Sat Aug 26 16:23:38 2000
Delivered-To: cvs-all@freebsd.org
Received: from palrel3.hp.com (palrel3.hp.com [156.153.255.226])
	by hub.freebsd.org (Postfix) with ESMTP
	id ED6F137B43E; Sat, 26 Aug 2000 16:23:35 -0700 (PDT)
Received: from adlmail.cup.hp.com (adlmail.cup.hp.com [15.0.100.30])
	by palrel3.hp.com (Postfix) with ESMTP
	id 6F3761247; Sat, 26 Aug 2000 16:23:35 -0700 (PDT)
Received: from cup.hp.com (p1000180.nsr.hp.com [15.109.0.180])
	by adlmail.cup.hp.com (8.9.3 (PHNE_18546)/8.9.3 SMKit7.02) with ESMTP id QAA01812;
	Sat, 26 Aug 2000 16:23:34 -0700 (PDT)
Message-ID: <39A85175.148F900D@cup.hp.com>
Date: Sat, 26 Aug 2000 16:23:33 -0700
From: Marcel Moolenaar <marcel@cup.hp.com>
Organization: Hewlett-Packard
X-Mailer: Mozilla 4.73 [en] (X11; U; Linux 2.2.12 i386)
X-Accept-Language: en
MIME-Version: 1.0
To: Doug White <dwhite@resnet.uoregon.edu>
Cc: Marcel Moolenaar <marcel@FreeBSD.org>,
	cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/compat/linux linux_socket.c
References: <Pine.BSF.4.21.0008261211250.40564-100000@resnet.uoregon.edu>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Doug White wrote:
> 
> On Fri, 25 Aug 2000, Marcel Moolenaar wrote:
> 
> > marcel      2000/08/25 22:12:18 PDT
> >
> >   Modified files:
> >     sys/compat/linux     linux_socket.c
> 
> Um, isn't this a no-no?  You're not supposed to re-style existing files;
> you generated a 700-line diff for no functional change.

I have functional changes to commit as well. It's definitely a no-no to
mix that with white-space fixes. If I can't resist myself to change
style as well while I'm coding, I'd better get the style issue out of my
way.

-- 
Marcel Moolenaar
  mail: marcel@cup.hp.com / marcel@FreeBSD.org
  tel:  (408) 447-4222


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message