From owner-freebsd-current Fri Dec 13 16:55:11 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 017A437B404; Fri, 13 Dec 2002 16:55:09 -0800 (PST) Received: from rwcrmhc53.attbi.com (rwcrmhc53.attbi.com [204.127.198.39]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6CB2643EC5; Fri, 13 Dec 2002 16:55:08 -0800 (PST) (envelope-from julian@elischer.org) Received: from InterJet.elischer.org (12-232-168-4.client.attbi.com[12.232.168.4]) by rwcrmhc53.attbi.com (rwcrmhc53) with ESMTP id <20021214005507053002k78he>; Sat, 14 Dec 2002 00:55:08 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id QAA12224; Fri, 13 Dec 2002 16:51:56 -0800 (PST) Date: Fri, 13 Dec 2002 16:51:54 -0800 (PST) From: Julian Elischer To: Peter Wemm Cc: Dan Nelson , Nate Lawson , Kevin Oberman , FreeBSD current users , re@freebsd.org Subject: Re: 5.0 showstopper In-Reply-To: <20021214004513.733AB2A7EA@canning.wemm.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 13 Dec 2002, Peter Wemm wrote: > Julian Elischer wrote: > > > > > > looking at the code in src/sys/i386/i386/dump_machdep.c, > > > > we see: > > 78 dumplo = di->mediaoffset + di->mediasize - Maxmem * > > (off_t)PAGE_SIZE; > > 79 dumplo -= sizeof kdh * 2; > > 80 i = di->dumper(di->priv, &kdh, 0, dumplo, sizeof kdh); > > 81 if (i) > > 82 printf("\nDump failed writing header (%d)\n", i); > > 83 dumplo += sizeof kdh; > > 84 i = 0; > > > > It looks like the following test should go after line 77 > > > > if (di->mediasize < ((Maxmem * (off_t)PAGE_SIZE) + > > (sizeof kdh * 2) + (16*1024)) { > > /* 16K is an arbitrary buffer > > * in case the swap part is > > * the first part > > */ > > printf("\nDump failed. Partition too small.\n"); > > return; > > } > > We used to force a 64K safety buffer for swapon, and I think we also did > 64K for dump before the last MI dump code conversion. I'd feel a little > happier if you used 64K here instead of 16K. I'm happy with 64k.. I just chose 16 arbitrarily because I remembered that there was SOME safety value but I couldn't remember what it was.. :-) does it look reasonable to you? > > > Cheers, > -Peter > -- > Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com > "All of this is for nothing if we don't go to the stars" - JMS/B5 > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message