From owner-cvs-all@FreeBSD.ORG Wed Jun 6 01:25:51 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.ORG Delivered-To: cvs-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7B96A16A400; Wed, 6 Jun 2007 01:25:51 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [210.51.165.229]) by mx1.freebsd.org (Postfix) with ESMTP id 3443213C483; Wed, 6 Jun 2007 01:25:51 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from localhost (tarsier.geekcn.org [210.51.165.229]) by tarsier.geekcn.org (Postfix) with ESMTP id 39D4BEB719E; Wed, 6 Jun 2007 09:25:50 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([210.51.165.229]) by localhost (mail.geekcn.org [210.51.165.229]) (amavisd-new, port 10024) with ESMTP id J9tUD8IOigfJ; Wed, 6 Jun 2007 09:25:44 +0800 (CST) Received: from LI-Xins-MacBook.local (sina152-194.staff.sina.com.cn [61.135.152.194]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTP id E0E35EB091C; Wed, 6 Jun 2007 09:25:41 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:organization:user-agent:mime-version:to:cc: subject:references:in-reply-to:x-enigmail-version:content-type; b=uEdL1sJkUU6W5fN3hf1p8zR7iJJ4nnm3XMX4+/rbn/58t7haN+47GBwp41ecGhW7h b70WYSEQ2cMsS7bO57tbQ== Message-ID: <46660D12.4050600@delphij.net> Date: Wed, 06 Jun 2007 09:25:38 +0800 From: LI Xin Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.0 (Macintosh/20070326) MIME-Version: 1.0 To: "M. Warner Losh" References: <200706050544.l555ifKp014690@repoman.freebsd.org> <20070605190601.GC1834@submonkey.net> <20070605.161442.1723940823.imp@bsdimp.com> In-Reply-To: <20070605.161442.1723940823.imp@bsdimp.com> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enig8A13177FB9A260F6DA651FB0" Cc: cvs-src@FreeBSD.ORG, ceri@submonkey.net, delphij@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/sysinstall installUpgrade.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jun 2007 01:25:51 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8A13177FB9A260F6DA651FB0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi, What about: %%% vsystem("disklabel -B `awk $2~/\\/$/ {print substr($1, 6, length($1)-6)} /etc/fstab`); %%% Well, I admit that replacing a piece of non-working code with a workaround is not generally a good idea, but I did not found a perfect solution yet, and it does not make us any good to leave an installer bug as is if the old code does not work at all :-) This is still not perfect (does not work on a root slice, for instance), but it would cover more cases and does not need yet another generator. Cheers, --=20 Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! --------------enig8A13177FB9A260F6DA651FB0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGZg0SOfuToMruuMARCvSRAKCAXBe7BtnRcCoTxPr2BYPEgTp1DQCgieJn 97DA5Qddmijo4anCP8RwG7g= =ItVo -----END PGP SIGNATURE----- --------------enig8A13177FB9A260F6DA651FB0--