Date: Sun, 27 Dec 2020 20:22:25 +0100 From: Mateusz Guzik <mjguzik@gmail.com> To: Mark Johnston <markj@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a1fc1f10c65f - main - Revert "cache: modification and last entry filling support in lockless lookup" Message-ID: <CAGudoHGP4vekRA7pgTzzmNjZLYeQv_HAM4pdQT67mtkNZj2EPA@mail.gmail.com> In-Reply-To: <X%2Bjb6UsTc8ewGJRk@raichu> References: <202012271904.0BRJ4DWF044873@gitrepo.freebsd.org> <X%2Bjb6UsTc8ewGJRk@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
I ran into it myself building one of the affected ports (devel/gettext-runtime). On 12/27/20, Mark Johnston <markj@freebsd.org> wrote: > On Sun, Dec 27, 2020 at 07:04:13PM +0000, Mateusz Guzik wrote: >> The branch main has been updated by mjg: >> >> URL: >> https://cgit.FreeBSD.org/src/commit/?id=a1fc1f10c65fe8684d09d2252c19ebb213182b4f >> >> commit a1fc1f10c65fe8684d09d2252c19ebb213182b4f >> Author: Mateusz Guzik <mjg@FreeBSD.org> >> AuthorDate: 2020-12-27 19:02:29 +0000 >> Commit: Mateusz Guzik <mjg@FreeBSD.org> >> CommitDate: 2020-12-27 19:02:29 +0000 >> >> Revert "cache: modification and last entry filling support in lockless >> lookup" >> >> This reverts commit 6dbb07ed6872ae7988b9b705e322c94658eba6d1. >> >> Some ports unreliably fail to build with rmdir getting ENOTEMPTY. > > I also got this when running the fs/tmpfs/rename_test:dots test > > panic: Assertion (cnp->cn_flags & ISDOTDOT) != 0 failed at > /usr/home/markj/src/freebsd-dev/sys/kern/vfs_cache.c:1663 > cpuid = 22 > time = 1609095767 > KDB: stack backtrace: > > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > 0xfffffe01aeb764b0 > vpanic() at vpanic+0x181/frame 0xfffffe01aeb76500 > panic() at panic+0x43/frame 0xfffffe01aeb76560 > cache_lookup_dotdot() at cache_lookup_dotdot+0x509/frame 0xfffffe01aeb765d0 > vfs_cache_lookup() at vfs_cache_lookup+0x7b/frame 0xfffffe01aeb76620 > cache_fplookup_final_modifying() at > cache_fplookup_final_modifying+0x1b5/frame 0xfffffe01aeb766a0 > cache_fplookup() at cache_fplookup+0x8f2/frame 0xfffffe01aeb767b0 > namei() at namei+0x17f/frame 0xfffffe01aeb76870 > kern_renameat() at kern_renameat+0x10c/frame 0xfffffe01aeb76ac0 > amd64_syscall() at amd64_syscall+0x12e/frame 0xfffffe01aeb76bf0 > fast_syscall_common() at fast_syscall_common+0xf8/frame 0xfffffe01aeb76bf0 > -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHGP4vekRA7pgTzzmNjZLYeQv_HAM4pdQT67mtkNZj2EPA>