From nobody Thu Sep 11 19:40:17 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cN7FG5BWBz67LXs; Thu, 11 Sep 2025 19:40:18 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cN7FG4jm8z3qBV; Thu, 11 Sep 2025 19:40:18 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757619618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JjwMBDEopXV39VnmQ94YkOeh0P9TX9d0EwYOAM0pYu4=; b=vLyrVBudSq24uCm0bu44nwNRFGpW8+qxKiT2hz3AC57bdKQ0pvBR7vq8Rojb/qHoY+8vyg j6evVEN2LQhSK0mdlLrFzFZNBF7x9vtIQVhERI5aRKl9IfmZY9YDZQz1vaZQrNTSU3eOcf Gq+KlaJ6eTH1v5OrM6h3q8ckT9mvMSrsUuXL3Qskh1tguG6NRnQY7OTm6OZQSRcLlCqBNj V/JFM+lSD4AfI+WYL2Zi6aVCXBLUomi3cKJOQhMWEyOlpqEMK7nLWxBjLjZpCJzyI4Bgsg Ar43NUtignVfkYAmSGLh92t3aSAImcdxC36saoFwQA0SH/3TJmBpUmMjApkz1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1757619618; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JjwMBDEopXV39VnmQ94YkOeh0P9TX9d0EwYOAM0pYu4=; b=cYaF+Sg1ramtfUXCPBmpMhtPKYX4Ohc0EhoO+jRJqrJCSsrLDTLxXQQ3mnjK1i8pXEDLAb m4SMhgLHYTpl9Hmh9UYYSp1icA+afTYMfatothWfRJt3gYVS/MO8Z34SMWyM6uXrXvg2cH Gzx5oKizv/LXqqXhFAvuAnrS42FG+WwyUO/o+r83l+mmSC2lG5EuarQ9lyMxooRK4vwc8j mjkS7vhvp+Ya2oOt+7x1um6hEUB9NCviUzlpuZTt7Cs9q5r9ubUQShhwmcSC9IdPQ4C2/Y pEhV8tcajq3CDuQnJWvLcSy0qzNaSBL3k+JyKbp5DISE+KAuabMq94P0cScuYA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1757619618; a=rsa-sha256; cv=none; b=QOvXu3umD6t4MHmlHvH7GpCwpJzZLlHRbKcsAz3YVrAjxsKn5+6rc9CwXMwFmSRVnskShG CQpNPmUqmQlH7QBmeaOKxx1Mz/Bjq5xDK/QiLv9ki7F79trkGTuTV+YPNQLa8o8n7N7Q3v a0FBjdyWeWbSS23O9iAU1SvgqZ12IuNN1Rja7g4oAYZh39lrgF7vfe1T0TTTy5V+f0hRBs NLe0hOB8QCN+txQsrVB1TuRv1UCSON3OnLRCWz6rdoGX4qaA4Ky+o75/6xfz4hfbO5YBbA D+SQGiZNMYCiGiJ/YH6/D8jD7A6qFGzNQ0epv819KaNXLClbN82/AczotQsC8g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:5c0:4202:5670:7c27:8c2d:b385:7578] (unknown [IPv6:2601:5c0:4202:5670:7c27:8c2d:b385:7578]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cN7FG2FxXz68S; Thu, 11 Sep 2025 19:40:18 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <75caa45d-aa73-4ee1-9d8d-e2f53f3cfe2a@FreeBSD.org> Date: Thu, 11 Sep 2025 15:40:17 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: d20c82507278 - main - Revert "libc: Remove readdir_r(3)" Content-Language: en-US To: Warner Losh , =?UTF-8?Q?Olivier_Cochard-Labb=C3=A9?= Cc: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202509111512.58BFCV87088340@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/11/25 12:57, Warner Losh wrote: > On Thu, Sep 11, 2025 at 10:27 AM Olivier Cochard-Labbé > wrote: > >> >> On Thu, Sep 11, 2025 at 8:12 AM Dag-Erling Smørgrav >> wrote: >> >>> The branch main has been updated by des: >>> >>> URL: >>> https://cgit.FreeBSD.org/src/commit/?id=d20c82507278e003f391c3fb04f4e49afd1537ab >>> >>> commit d20c82507278e003f391c3fb04f4e49afd1537ab >>> Author: Dag-Erling Smørgrav >>> AuthorDate: 2025-09-11 15:12:22 +0000 >>> Commit: Dag-Erling Smørgrav >>> CommitDate: 2025-09-11 15:12:22 +0000 >>> >>> Revert "libc: Remove readdir_r(3)" >>> >>> This reverts commit d549de769055ae6116601e54e4c86dfb3e17f4c4. >>> >>> >> Hi Dag-Erling, >> Could you please explain why this change was reversed? >> Because the reason was missing from this commit message. >> > > Rust breaks with this change. While rust can be fixed (and will be) since > it's doing some sketch things and the fix is to just remove the sketch > stuff. However, part of Rust's work flow is to do A/B testing between new > runs under test, and older Rust versions. The old binaries work fine, but > newly-built copies of the old versions do not. Until those old versions > 'age out' of this setup, we'll be stuck with this. That's a good reason, but I think the point about the commit log stands. A commit log for a revert that is unedited and just "Revert foo" isn't useful. Developers need to edit the log message to add the why. The above paragraph belonged in the commit log. -- John Baldwin