From nobody Tue Jan 20 04:09:41 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dwDP22TkVz6Nw6H for ; Tue, 20 Jan 2026 04:09:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dwDP154nBz3Vtg for ; Tue, 20 Jan 2026 04:09:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768882181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Wg6j9htLrmOWWNmnNGEA+W2Lmx0hmLQ9DlcB4Q66+YU=; b=SQe0PIAfc54T5T+wRiEW3TzUJ0l+WfgSQi/mnzV4i9LzhXjV4avSm0XvQs3JLA6v0SV+Se InyBGSl6Z8VOtXuAzSAVt2TgSZ5X7bsvneMaBb2g2+xBnjZUUoautH/KvmLYNuDoRCI8Yl vto67TqyX//Bg/7iofMk7M5D1XAM5RPlLUBis8AOquplcx1bw036u96fCzabUml79jHxkU Ys+x2w/sDWLq8LdGizo3hBaLVQh9ZuWWvdpnX8vNavOkQ5eRLRGuUr5zrYf/Y1SAYOICwf YKFj1vGLGO/wDXZMUmdbFuTm5wHdivkpRP8a1WySUIKsQNqF29Dxh4V1/OwLiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768882181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Wg6j9htLrmOWWNmnNGEA+W2Lmx0hmLQ9DlcB4Q66+YU=; b=JYq3ZDNMHb6RD/wseAqT+TJIBzTUzFCcaF7K/x3mf8Iw17sEnbXZ/N4rExMcMfSb+oaazn 4CKCeGT31BVnXk50m6i2J0NWch/dWHzowrJDcUcBEwtGyLTU2BBsvJGRNPils83EuaDgEK F4fFyzMJsCdnwSCPVVw2vsjzGNQPHMuFV1tw7IUIFmiw/9V3VaLVhYGwadQTE0eNHxZmPg Cap5bPIRUQUxv13Fl6JrDQ74ac2uDtAsnYQN03mfoIAEnvG8RA5GW3F6HRTsH1ENz9Ws19 Pl7ZcS+PTeSC+uo8KhCnTSntZkZDuf88CkQnNnEyTi0A6ko7igmXuRmRt4hCSA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768882181; a=rsa-sha256; cv=none; b=oRricO0zwvISgn/JpxxK0PH8BTdfkVAiDovubx8OyrvbbPQ1sRZJdg+2kZuMRAuwKXMi4l uF5m339vSMbRXfd+Z9Y9G9YojA6Xiax5S2aXwoTo2eBPuUVfnCcP/1sGwE6BhUGR1dstmV TdcpeiqbFlP7+huqYXBXmw3C+U8vS8DCY4cFdwr8oKgaWM5jAllxDWcqICAlSdwznGUB1P rrmwVuLkGvIvu+Lb3IQ9iHNzmb48+SwgFzmGcap1AKPUcV3x2HEaxsM5XfCmOfoisn8Yaq QZlwoTs3Wlz3A9ee+BUcl6kORZsrmoDYFt4PgBvVDavusZHxQHG80ArZHirbeg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dwDP14dwDz127h for ; Tue, 20 Jan 2026 04:09:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26a60 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 20 Jan 2026 04:09:41 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Kyle Evans Subject: git: d3c523b6f5aa - stable/14 - makedev(9): drop an additional note about cdevpriv dtors List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kevans X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: d3c523b6f5aa644e85d7c2c1177953f5d73e8529 Auto-Submitted: auto-generated Date: Tue, 20 Jan 2026 04:09:41 +0000 Message-Id: <696f0005.26a60.7c9df80d@gitrepo.freebsd.org> The branch stable/14 has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=d3c523b6f5aa644e85d7c2c1177953f5d73e8529 commit d3c523b6f5aa644e85d7c2c1177953f5d73e8529 Author: Kyle Evans AuthorDate: 2025-11-05 00:28:02 +0000 Commit: Kyle Evans CommitDate: 2026-01-20 04:07:00 +0000 makedev(9): drop an additional note about cdevpriv dtors These were previously somewhat safe to call destroy_dev(9), but will now also cause a deadlock in the same fashion that d_close doing so would previously. Amend the note to point it out, in case it's useful for someone. Reviewed by: imp, kib, markj (cherry picked from commit 90314c04f10f583c37c59ec51fd628e3deaf3622) --- share/man/man9/make_dev.9 | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/share/man/man9/make_dev.9 b/share/man/man9/make_dev.9 index 052f9a0cfd87..c8f495c2777b 100644 --- a/share/man/man9/make_dev.9 +++ b/share/man/man9/make_dev.9 @@ -25,7 +25,7 @@ .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" SUCH DAMAGE. .\" -.Dd January 19, 2025 +.Dd November 4, 2025 .Dt MAKE_DEV 9 .Os .Sh NAME @@ -387,14 +387,18 @@ function is the same as: destroy_dev_sched_cb(cdev, NULL, NULL); .Ed .Pp -The +Neither the .Fn d_close -driver method cannot call +driver method, nor a +.Xr devfs_cdevpriv 9 +.Fa dtr +method can .Fn destroy_dev directly. Doing so causes deadlock when .Fn destroy_dev -waits for all threads to leave the driver methods. +waits for all threads to leave the driver methods and finish executing any +per-open destructors. Also, because .Fn destroy_dev sleeps, no non-sleepable locks may be held over the call.