From owner-cvs-all  Wed May 22  4:36:26 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7A75737B40A; Wed, 22 May 2002 04:36:15 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id VAA25682;
	Wed, 22 May 2002 21:36:05 +1000
Date: Wed, 22 May 2002 21:38:53 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Jake Burkholder <jake@locore.ca>
Cc: Ruslan Ermilov <ru@FreeBSD.org>, <cvs-committers@FreeBSD.org>,
	<cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/usr.bin/elf2aout elf2aout.c
In-Reply-To: <20020520144919.D62759@locore.ca>
Message-ID: <20020522211222.X9440-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 20 May 2002, Jake Burkholder wrote:

> Apparently, On Mon, May 20, 2002 at 08:24:31PM +0300,
> 	Ruslan Ermilov said words to the effect of;
>
> > On Mon, May 20, 2002 at 07:17:39PM +0300, Ruslan Ermilov wrote:
> > > On Mon, May 20, 2002 at 12:15:14PM -0400, Jake Burkholder wrote:
> > > > Apparently, On Mon, May 20, 2002 at 12:56:40AM -0700,
> > > > 	Ruslan Ermilov said words to the effect of;
> > > >
> > > > > ru          2002/05/20 00:56:40 PDT
> > > > >
> > > > >   Modified files:
> > > > >     usr.bin/elf2aout     elf2aout.c
> > > > >   Log:
> > > > >   s/u_int/u_int32_t/
> > > >
> > > > I would have preferred you to not commit this, it does nothing.
> > > >
> > > It makes code more MI, as u_int is not guaranteed to be 32 bit.
> > > This also makes it explicit that we're dealing with the elf32
> > > here, not elf64.
> > >
> > These would even better be declared using the Elf32_* types.
> > Could you please fix this?
>
> Umm, its an a.out header.  u_int{,32_t} is correct.

Actually, a fixed-width unsigned integer type with the same number of
bits as `unsigned long' on the target machine is correct, since the
type in a target struct exec is `unsigned long' (see <sys/imgact.h>).
`unsigned long' for all targets is inconvenient for cross-compiling
and gratuitously compiler-dependent, but it was almost as good as
possible since it was the largest integer type. `u_int' for all targets
would be just broken since it might be 16 bits.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message