From owner-svn-src-head@FreeBSD.ORG  Fri Dec 21 21:49:15 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 86C9DB89;
 Fri, 21 Dec 2012 21:49:15 +0000 (UTC)
 (envelope-from jim.harris@gmail.com)
Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com
 [209.85.212.182])
 by mx1.freebsd.org (Postfix) with ESMTP id 858DF8FC0C;
 Fri, 21 Dec 2012 21:49:14 +0000 (UTC)
Received: by mail-wi0-f182.google.com with SMTP id hn14so3043763wib.3
 for <multiple recipients>; Fri, 21 Dec 2012 13:49:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=E7q3Pc8HNwr+BNUIoVCopi6Lt7ZBzIEbEaLHYFf6YEQ=;
 b=XhN3EoqdmNCXiWDmX8bYfpLraoZPjIFoRa5+OQZv3wtDiZJKTAdnScIWhUeViB76/q
 rxYn0A4Ts4fdf2TRfgCCtdPWn6gZI8ym/40rm437u5UgjZuI4yFXgPs7JZE6Hhkj00OY
 mOtFw1ZemEo1wS/cu/h2K+e/DFcjLlmRU68JOHX1ktJa+VDc9yuvWM+zH0dnpPweKfP4
 OJR5N4yNN7/rG/8xLQenSNQ/lrVAUHWTGsEGkeCup8+H1Qd6CHc8Lp2oNer9F9DEdCRS
 I2W7PYsuFp0QFQuoicdJ8Xp4CGadgpe56dVBROdm0/hlrtdSe4vnlSPS4H3FAYXOne/i
 +pWQ==
MIME-Version: 1.0
Received: by 10.180.103.136 with SMTP id fw8mr17778853wib.27.1356126553325;
 Fri, 21 Dec 2012 13:49:13 -0800 (PST)
Received: by 10.217.57.4 with HTTP; Fri, 21 Dec 2012 13:49:13 -0800 (PST)
In-Reply-To: <201212211424.16934.jhb@freebsd.org>
References: <201212211913.qBLJDmpm019837@svn.freebsd.org>
 <201212211424.16934.jhb@freebsd.org>
Date: Fri, 21 Dec 2012 14:49:13 -0700
Message-ID: <CAJP=Hc9PvmR5yUMH5=YvQ9e+tJ7j3PqtDHGebA8nvvTqB+X=xw@mail.gmail.com>
Subject: Re: svn commit: r244549 - head/sys/dev/nvme
From: Jim Harris <jim.harris@gmail.com>
To: John Baldwin <jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Dec 2012 21:49:15 -0000

On Fri, Dec 21, 2012 at 12:24 PM, John Baldwin <jhb@freebsd.org> wrote:

> On Friday, December 21, 2012 2:13:48 pm Jim Harris wrote:
> > Author: jimharris
> > Date: Fri Dec 21 19:13:48 2012
> > New Revision: 244549
> > URL: http://svnweb.freebsd.org/changeset/base/244549
> >
> > Log:
> >   Put kthreads under curproc so they are attached to nvmecontrol rather
> >   than pid 0.
> >
> >   Sponsored by:       Intel
>
> Hmm, is this really wise?  I'm not sure how well the kernel would handle a
> kthread belonging to a userland process.  You could just have each test
> create a new kproc that holds the associated threads for that test instead
> perhaps?
>
>
Just so I'm aware, what sorts of problems might you expect if a kthread
belongs to a userland process?  I'm not opposed to changing this as you
suggest, but would like to know for my own understanding since I haven't
observed any problems with it on my system.

Another benefit of using kproc here though would be to make it more
consistent with pre-8.0 behavior (before kthread_create was renamed to
kproc_create).