From owner-svn-src-all@FreeBSD.ORG  Sat Dec 15 00:14:38 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id E041413A;
 Sat, 15 Dec 2012 00:14:38 +0000 (UTC) (envelope-from smh@freebsd.org)
Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23])
 by mx1.freebsd.org (Postfix) with ESMTP id D0DC28FC0A;
 Sat, 15 Dec 2012 00:14:37 +0000 (UTC)
X-Spam-Processed: mail1.multiplay.co.uk, Sat, 15 Dec 2012 00:14:35 +0000
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on
 mail1.multiplay.co.uk
X-Spam-Level: 
X-Spam-Status: No, score=-5.0 required=6.0 tests=USER_IN_WHITELIST
 shortcircuit=ham autolearn=disabled version=3.2.5
Received: from r2d2 ([188.220.16.49])
 by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23])
 (MDaemon PRO v10.0.4) with ESMTP id md50001358603.msg;
 Sat, 15 Dec 2012 00:14:35 +0000
X-MDRemoteIP: 188.220.16.49
X-Return-Path: smh@freebsd.org
X-Envelope-From: smh@freebsd.org
Message-ID: <2684CC03E9F64F72B9F723411F32DF68@multiplay.co.uk>
From: "Steven Hartland" <smh@freebsd.org>
To: "Pawel Jakub Dawidek" <pjd@FreeBSD.org>
References: <201212131739.qBDHd8RR083616@svn.freebsd.org>
 <20121214220547.GC1411@garage.freebsd.pl>
Subject: Re: svn commit: r244188 -
 head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
Date: Sat, 15 Dec 2012 00:14:28 -0000
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="iso-8859-1";
 reply-type=original
Content-Transfer-Encoding: 7bit
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.5931
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Dec 2012 00:14:39 -0000

----- Original Message ----- 
From: "Pawel Jakub Dawidek" <pjd@FreeBSD.org>
On Thu, Dec 13, 2012 at 05:39:08PM +0000, Steven Hartland wrote:
>> Author: smh
>> Date: Thu Dec 13 17:39:07 2012
>> New Revision: 244188
>> URL: http://svnweb.freebsd.org/changeset/base/244188
>> 
>> Log:
>>   Added vfs.zfs.vdev.trim_on_init sysctl which allows full vdev trim on
>>   initialisation to be enabled (1) / disabled (0) defaults to enabled.
>>   
>>   This is useful for devices which have a slow trim speed and are either
>>   new or have otherwise already been wiped e.g. secure erase.
>>   
...
>> +static boolean_t vdev_trim_on_init = B_TRUE;
>> +SYSCTL_DECL(_vfs_zfs_vdev);>
>> +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, trim_on_init, CTLFLAG_RW,
>> +    &vdev_trim_on_init, 0, "Enable/disable full vdev trim on initialisation");
> 
> I'd also make it loader tunable.

Will look into that, worth doing the other SYSCTL only ones at the same time?

    Regards
    Steve