From owner-freebsd-x11@freebsd.org Wed Jan 13 21:43:41 2016 Return-Path: Delivered-To: freebsd-x11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E3E69A818F0 for ; Wed, 13 Jan 2016 21:43:41 +0000 (UTC) (envelope-from n.pajkovsky@gmail.com) Received: from mail-wm0-x22f.google.com (mail-wm0-x22f.google.com [IPv6:2a00:1450:400c:c09::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7AE491002 for ; Wed, 13 Jan 2016 21:43:41 +0000 (UTC) (envelope-from n.pajkovsky@gmail.com) Received: by mail-wm0-x22f.google.com with SMTP id f206so393310434wmf.0 for ; Wed, 13 Jan 2016 13:43:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type:content-transfer-encoding; bh=u2/ZbAVpUl/XmjtEGB3HUUQFSkHkgsUSp24kfrVJUVk=; b=FgXup/NAVwGsP+0h8uow9agMLYpfkdKwviOB0HUIljM9lm0UUDVceRnpkHsBjAPzK9 V79W+Gs6FuK/p6dqRRnBir+BIQDidINQSy3gEspHw6HEfq8INYmY8g1lN6xyuGK7VBnd sILjHIHaFTAptFtm+5Py2VJHvukRFnPtyoT8kY52netrO0JfOd1qhho170++t46RZo4X c3Bp/P7Clb2W4DFWceCBXBAm9gMbXjurcV1KcyABeoYm/WBBITap9KvVzsBNXnFO5Zj8 WfhbCVKYrRMFJMIFAucbne6xuveuSmUhwgmQrY8+pDBMfHtn3xDbl/7HaSExC+ctT2oI /pQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type :content-transfer-encoding; bh=u2/ZbAVpUl/XmjtEGB3HUUQFSkHkgsUSp24kfrVJUVk=; b=gTrTaQpgVWOJUWWpeB+bqlviYQhIdmu1sp8RG7s6oM/KHKCKCzPN3rMncriSS8TCIJ SCatxQeuirsUaUrB99tRIk7SEwQat7uzjHkEGkPPHDqx1PRou7Z24mptLS+NJyHUimXa YczxslTHsnBAXIWxrfdtqLxwVWmaBPTJ+EavTd6J5hYE6jSodrtGUU6Cbo5Ce34JJC33 qggPeFmooK6qR3x3W3+J6z7kTFW5XzO4uKJZtUgiCJu6Z4EzOLJsb7Kt6LU+RtAhCO3w EcvG9qLymzL0tOWANFmYyrzfnGZOfNJqKyI5y74KSvbmivYMOuClyqxDYFs3E33bVAsp /RoQ== X-Gm-Message-State: ALoCoQkjvFY+G1IzMkEIvmVmMgAb+jdsJIUEYntjQyvPssK23Fk77Pc+REn+cBDDe/ZGmaKNI0R+8RV1oYUi05mq/gTPP4u1ww== X-Received: by 10.194.116.170 with SMTP id jx10mr404795wjb.166.1452721420043; Wed, 13 Jan 2016 13:43:40 -0800 (PST) Received: from localhost (ip-89-176-25-139.net.upcbroadband.cz. [89.176.25.139]) by smtp.gmail.com with ESMTPSA id bg10sm3154628wjb.46.2016.01.13.13.43.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jan 2016 13:43:38 -0800 (PST) From: Nikola Pajkovsky X-Google-Original-From: Nikola Pajkovsky To: =?utf-8?Q?Jean-S=C3=A9bastien_P=C3=A9dron?= Cc: freebsd-x11@freebsd.org Subject: Re: build-able drm-i915-update-38 In-Reply-To: <5696A19A.2030009@dumbbell.fr> (=?utf-8?Q?=22Jean-S=C3=A9bast?= =?utf-8?Q?ien_P=C3=A9dron=22's?= message of "Wed, 13 Jan 2016 20:12:26 +0100") References: <87oacpdguk.fsf@gooddata.com> <5696A19A.2030009@dumbbell.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (berkeley-unix) Date: Wed, 13 Jan 2016 22:43:37 +0100 Message-ID: <864mehduk6.fsf@freebsd.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 21:43:42 -0000 Jean-S=C3=A9bastien P=C3=A9dron writes: > On 13/01/2016 09:27, Nikola Pajkovsky wrote: >> I was trying build HEAD drm-i915-update-38, and I found it, it does not >> build. Can we please push only changes, which does build? > > Hi! > > I rebuild a full kernel from scratch and it does build fine here. There > is no "unused variable" warning for me. Do you build a non-debug kernel > perhaps? I don't plan to build-test such a kernel now, I'll do it when > the patch is finished. Oh, everytime? I have found out, that $ cd sys/modules/drm2 $ make -j9 $ make DESTDIR=3D/boot/ KMODDIR=3Dkernel.i915 install is engough (only after I have fully built and booted kernel) =3D=3D=3D> drm2 (all) Warning: Object directory not changed from original /usr/home/npa/freebsd-b= ase-graphics/sys/modules/drm2/drm2 =3D=3D=3D> i915kms (all) Warning: Object directory not changed from original /usr/home/npa/freebsd-b= ase-graphics/sys/modules/drm2/i915kms cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc= -I. -I/usr/home/npa/freebsd-base-graphics/sys/modules/drm2/i915kms/../..= /.. -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -mcm= odel=3Dkernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchrono= us-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant= -decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer= -arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=3D__fre= ebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unkn= own-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-er= ror-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sig= n -Wno-error-shift-negative-value -mno-aes -mno-avx -std=3Diso9899:1999 -= c /usr/home/npa/freebsd-base-graphics/sys/modules/drm2/i915kms/../../../dev= /drm2/i915/i915_gem_gtt.c -o i915_gem_gtt.o /usr/home/npa/freebsd-base-graphics/sys/modules/drm2/i915kms/../../../dev/d= rm2/i915/i915_gem_gtt.c:451:12: error: unused variable 'max_entries' [-Werr= or,-Wunused-variable] const int max_entries =3D dev_priv->mm.gtt->gtt_total_entries - fir= st_entry; ^ 1 error generated. *** Error code 1 code in i915_gem_gtt.c gen6_ggtt_bind_object() const int max_entries =3D dev_priv->mm.gtt->gtt_total_entries - first_e= ntry; BUG_ON(i > max_entries); Seems like BUG_ON is noop, which should not be. >> I can send you patch to fix it later on today. I'm going to try start >> syncing drm with v3.9 today. Where do you want me to send patches, >> freebsd-x11 or pull request in github? > > For the warning, it can be a pull request on the drm-i915-update-38 > branch. I will create drm-next-3.9 branch too for you to start. Ok, thanks.