From owner-svn-src-head@freebsd.org Sat Feb 16 06:42:31 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6467314D7164; Sat, 16 Feb 2019 06:42:31 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 592CE75A15; Sat, 16 Feb 2019 06:42:30 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x530.google.com with SMTP id b2so140675pgl.9; Fri, 15 Feb 2019 22:42:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=zkdb4mIa9NDD2RmxQdb3pHptE/SNOZlGnPtjf1+tbuY=; b=pGeCrxh2XQQHd8aY7tUMT2WM3+ZRDerZkF3UDQIJkFbzJwGv9ZrpN4+2i9Vxd7G6c2 yEOCG5nB3gkGzpjBLj4yMHh0ybt8SHrLmYa+9RLH39TMPDjHEVXuLfE02IPQmwl9Ixd1 MGQ/9N5FP6k/JNIByNOQXfU6iXNkgYyTv3pTq2TyXVmUxl8ac1zMUMkYb1VsIdcDx4tI eilq2wzQ7/MWHUQy579eY+ZNta/k8fFyntPqTbaykEb7oXybLxkm1gVeBoCVNVdrPdZU fPR0KDBZzh4A8ddrPgXxybEl0UO09SABLq81lMlQtb1dhxaZ4LZL/Z41ek6Jg4q2aMjA lXQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=zkdb4mIa9NDD2RmxQdb3pHptE/SNOZlGnPtjf1+tbuY=; b=CztLwI6SBgcynJUrOibju0SE8Kkpldy177Wi3F8Xiap3/azozh1aYGNGaa7dbUT7Gb Zrg7lylbbe2mh8bJ4+7jRyVishw6dOTbZ1W1k1d/kMp+C0/hBoGASyzG1Qxg+Zvcb+IS M77toxW4tJZqW4Ostb2mRCeE7bHoLQdsGA04RQ84CuxmqlAmWqdRrJm6HFSYV+OHhfmD mRBO4WtlP7yJig8H15ofExUyszTdS01yj0OZioQj4YBT3ShJuWyS1OKP+B3jpuI4i9pz N3Wx1ZJXigv9YEpmIT5hdFR5kCAVOlLk2L2SFO183DTLBpBgYKULMgYZqH1DPeL/6mDu MlLA== X-Gm-Message-State: AHQUAuagCY430LPysE4/gu4DCyRg+ckN5HzdLmA7dq+uD754nPXgLXO9 VmWQ++8U7meK7AJAL4HmtjfdOFBb X-Google-Smtp-Source: AHgI3IYBEc+tJC5q9jH986EX7xgkq8ZuOeo4QH33ZrnO9fUreFjl61alNSFRgYCmrgy76E35unoZHA== X-Received: by 2002:a63:5b48:: with SMTP id l8mr8958832pgm.80.1550299348806; Fri, 15 Feb 2019 22:42:28 -0800 (PST) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id x23sm20720592pfe.0.2019.02.15.22.42.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Feb 2019 22:42:28 -0800 (PST) From: Enji Cooper Message-Id: Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r344191 - head/sbin/nvmecontrol Date: Fri, 15 Feb 2019 22:42:27 -0800 In-Reply-To: Cc: Warner Losh , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: Warner Losh References: <201902160015.x1G0F3EJ060777@repo.freebsd.org> X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: 592CE75A15 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=pGeCrxh2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::530 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-5.15 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MV_CASE(0.50)[]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.82)[-0.820,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; IP_SCORE(-2.82)[ip: (-9.44), ipnet: 2607:f8b0::/32(-2.59), asn: 15169(-1.99), country: US(-0.07)]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[0.3.5.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Feb 2019 06:42:31 -0000 > On Feb 15, 2019, at 10:25 PM, Warner Losh wrote: >=20 > On Fri, Feb 15, 2019, 9:55 PM Enji Cooper wrote: >=20 > > On Feb 15, 2019, at 16:15, Warner Losh > wrote: > >=20 > > Author: imp > > Date: Sat Feb 16 00:15:02 2019 > > New Revision: 344191 > > URL: https://svnweb.freebsd.org/changeset/base/344191 = > >=20 > > Log: > > Remove write-only s_flag. > >=20 > > Modified: > > head/sbin/nvmecontrol/firmware.c > >=20 > > Modified: head/sbin/nvmecontrol/firmware.c > > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > > --- head/sbin/nvmecontrol/firmware.c Fri Feb 15 23:46:34 2019 = (r344190) > > +++ head/sbin/nvmecontrol/firmware.c Sat Feb 16 00:15:02 2019 = (r344191) > > @@ -177,7 +177,7 @@ static void > > firmware(const struct nvme_function *nf, int argc, char *argv[]) > > { > > int fd =3D -1, slot =3D 0; > > - int a_flag, s_flag, f_flag; > > + int a_flag, f_flag; > > int activate_action, reboot_required; > > int opt; > > char *p, *image =3D NULL; > > @@ -188,7 +188,7 @@ firmware(const struct nvme_function *nf, int = argc, cha > > uint8_t fw_slot1_ro, fw_num_slots; > > struct nvme_controller_data cdata; > >=20 > > - a_flag =3D s_flag =3D f_flag =3D false; > > + a_flag =3D f_flag =3D false; > >=20 > > while ((opt =3D getopt(argc, argv, "af:s:")) !=3D -1) { >=20 > Hi Warner! > Should =E2=80=9Cs:=E2=80=9D be removed here, along with any = corresponding documentation about =E2=80=98-s foo=E2=80=99? >=20 > The docs are poo. s: should not be removed, since it is the slot and = required. The code set slot and s_flag. The latter is bogus, so I = removed it. 0-o.. I see. Ok, carry on! -Enji=