From owner-dev-commits-ports-main@freebsd.org Wed Jun 2 04:49:01 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E0B9D639F66; Wed, 2 Jun 2021 04:49:01 +0000 (UTC) (envelope-from ygy@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FvxPn3NwNz3lWB; Wed, 2 Jun 2021 04:49:01 +0000 (UTC) (envelope-from ygy@freebsd.org) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: ygy) by smtp.freebsd.org (Postfix) with ESMTPSA id 4D985E63; Wed, 2 Jun 2021 04:49:01 +0000 (UTC) (envelope-from ygy@freebsd.org) Received: by mail-wr1-f53.google.com with SMTP id l2so838170wrw.6; Tue, 01 Jun 2021 21:49:01 -0700 (PDT) X-Gm-Message-State: AOAM5339Y3TZRngT3Drzz4IfCQwbO+0cizA8XR7bqoKWUFw5rpepYnEc w4XG53VtG5UYDvKRhiZRvafdajSIdgqngaB++Y8= X-Google-Smtp-Source: ABdhPJz4oQC1JWKNFH8pYHxp7E1eE/VYl7mSqF0gP+YYhDv+Kp6Ykdo5u9kibSYGJbchdd6srR2KqVputAyRoQiJtso= X-Received: by 2002:a5d:4408:: with SMTP id z8mr14845573wrq.336.1622609340047; Tue, 01 Jun 2021 21:49:00 -0700 (PDT) MIME-Version: 1.0 References: <202106020218.1522Io42007503@gitrepo.freebsd.org> In-Reply-To: From: Guangyuan Yang Date: Wed, 2 Jun 2021 00:48:48 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: f1e718499cb3 - main - www/civetweb: New port: Embedded C/C++ web server To: Alexey Dokuchaev Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, Li-Wen Hsu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 04:49:02 -0000 Alexey Dokuchaev =E4=BA=8E2021=E5=B9=B46=E6=9C=882=E6= =97=A5=E5=91=A8=E4=B8=89 =E4=B8=8A=E5=8D=8812:16=E5=86=99=E9=81=93=EF=BC=9A > > Looks like it was not thorougly reviewed prior to approval. > > This text makes a nice COMMENT, ... > > ... but very bad port description. It should not be the same as COMMENT > verbatim. I should also terminate with a full stop (period). Please > (re)read the PHB Section 3.2.1 on how a good pkg-descr file should look > like. (Your mentor should have told you this.) Thanks for your friendly and constructive feedback, I agree that terminating with a full stop is a lot better. In this case, I will change pkg-descr to the following: "civetweb is a C/C++ embeddable web server with optional CGI, SSL and Lua support." There is no need to point fingers - if you take a look at the project website, there really isn't any more useful information to add. I would love to update it further if you have a better version. Also, I assure you that the review process has been closely followed, but thanks for your concern. --=20 Guangyuan Yang ygy@FreeBSD.org