Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 11 Dec 2019 19:32:52 +0000 (UTC)
From:      Kyle Evans <kevans@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r355628 - head/sys/tools
Message-ID:  <201912111932.xBBJWq91050049@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kevans
Date: Wed Dec 11 19:32:52 2019
New Revision: 355628
URL: https://svnweb.freebsd.org/changeset/base/355628

Log:
  makesyscalls.lua: trim trailing spaces/commas from args
  
  These are insignificant as far as declarations go, and we've historically
  allowed it. fhlinkat in ^/sys/kern/syscalls.master, for example, currently
  has a trailing comma after its final argument that this version of
  makesyscalls is ignoring (not by conscious decision).
  
  Fix it for now by actively stripping off trailing whitespace/commas until
  we decide to actively prohibit it.

Modified:
  head/sys/tools/makesyscalls.lua

Modified: head/sys/tools/makesyscalls.lua
==============================================================================
--- head/sys/tools/makesyscalls.lua	Wed Dec 11 18:50:23 2019	(r355627)
+++ head/sys/tools/makesyscalls.lua	Wed Dec 11 19:32:52 2019	(r355628)
@@ -1010,6 +1010,7 @@ process_syscall_def = function(line)
 			abort(1, "Not a signature? " .. line)
 		end
 		args = line:match("^[^(]+%((.+)%)[^)]*$")
+		args = trim(args, '[,%s]')
 	end
 
 	::skipalt::



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201912111932.xBBJWq91050049>