From owner-svn-src-all@FreeBSD.ORG Tue Jan 6 22:00:36 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1175C166; Tue, 6 Jan 2015 22:00:36 +0000 (UTC) Received: from mail-ig0-x233.google.com (mail-ig0-x233.google.com [IPv6:2607:f8b0:4001:c05::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C82326635E; Tue, 6 Jan 2015 22:00:35 +0000 (UTC) Received: by mail-ig0-f179.google.com with SMTP id r2so344248igi.6; Tue, 06 Jan 2015 14:00:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=9jBHsITh4mOgwdY+GEukPAtq2KydJFAv0oW2GoOuoG8=; b=N8LlQVDGsMsCh8VyQZPOQirG8UDoJKgluS8/oK+ilhekWkmfbOjGQhgP533sTERN3t 73ezmFKjiCNLuhpmcMgMP+zsLSSIkevFvwx7rjcNMZuHDxEssUFQOX2WcS2aymoe+lnC jYFexEOk93IQhOWT90YE0iYuc2HvqVez2zwjetaCxcQtWFjgvFhjtFFCl0fT6TyQX5n7 oAuDw8Usr7mGIqZgAyYbnV2uOnQnuuC5fkD9S6meBNqGBlOB1sDpthK5ObdWOMZAf0oN nkyKEVeavTXMFk9KG27VZQDQ8FVfBCaG0yvhHzvsCDowxLVTRQql96VNyeF3MvYLqAni WXDA== X-Received: by 10.50.120.7 with SMTP id ky7mr581405igb.45.1420581635219; Tue, 06 Jan 2015 14:00:35 -0800 (PST) MIME-Version: 1.0 Sender: mr.kodiak@gmail.com Received: by 10.64.0.171 with HTTP; Tue, 6 Jan 2015 14:00:04 -0800 (PST) In-Reply-To: References: <201410100609.s9A690NU067686@svn.freebsd.org> From: Bryan Venteicher Date: Tue, 6 Jan 2015 16:00:04 -0600 X-Google-Sender-Auth: G7rOhtv05OnTlqzEVZd0KK448hE Message-ID: Subject: Re: svn commit: r272886 - in head/sys: netinet netinet6 To: John Nielsen Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18-1 Cc: "svn-src-head@freebsd.org" , Bryan Venteicher , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jan 2015 22:00:36 -0000 On Tue, Jan 6, 2015 at 2:52 PM, John Nielsen wrote: > Bryan- > > On Oct 10, 2014, at 12:09 AM, Bryan Venteicher wrote: > > > Author: bryanv > > Date: Fri Oct 10 06:08:59 2014 > > New Revision: 272886 > > URL: https://svnweb.freebsd.org/changeset/base/272886 > > > > Log: > > Add context pointer and source address to the UDP tunnel callback > > > > These are needed for the forthcoming vxlan implementation. The context > > pointer means we do not have to use a spare pointer field in the inpcb, > > and the source address is required to populate vxlan's forwarding table. > > > > While I highly doubt there is an out of tree consumer of the UDP > > tunneling callback, this change may be a difficult to eventually MFC. > > I noticed this comment while doing an MFC of vxlan to my local tree. Do > you think an MFC to 10-STABLE of this change (and vxlan generally) will be > feasible? Is there precedent for ABI changes like this being sanctioned? > Could symbol versioning help? > > I'd like to get some consensus on whether this commit is OK to MFC. With this commit, vxlan should be an easy to MFC. > > Phabricator: https://reviews.freebsd.org/D383 > > Reviewed by: gnn > > > > Modified: > > head/sys/netinet/sctputil.c > > head/sys/netinet/udp_usrreq.c > > head/sys/netinet/udp_var.h > > head/sys/netinet6/udp6_usrreq.c > > Thanks, > > JN > >