Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 22 Apr 2017 10:54:29 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 215878] New port: devel/jucipp lightweight C++-IDE with support for C++11, C++14 and C++17
Message-ID:  <bug-215878-13-tMGWRqnJYf@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-215878-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-215878-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D215878

Tobias Kortkamp <tobik@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
                 CC|                            |tobik@freebsd.org
           Assignee|freebsd-ports-bugs@FreeBSD. |tobik@freebsd.org
                   |org                         |

--- Comment #2 from Tobias Kortkamp <tobik@freebsd.org> ---
Would be great to have indeed!  But there are some problems that need
to be fixed first.  See my comments below.

XCATEGORIES=3D    devel

Why devel and not editors?

XBUILD_DEPENDS+=3D        aspell>=3D0:textproc/aspell
XRUN_DEPENDS+=3D  aspell>=3D0:textproc/aspell
X
XBUILD_DEPENDS+=3D        boost-libs>=3D1.54.0:devel/boost-libs
XRUN_DEPENDS+=3D  boost-libs>=3D1.54.0:devel/boost-libs
X
...
X
XBUILD_DEPENDS+=3D        libgit2>=3D0:devel/libgit2
XRUN_DEPENDS+=3D  libgit2>=3D0:devel/libgit2
X

This is almost certainly wrong.  Did you mean LIB_DEPENDS?

XBUILD_DEPENDS+=3D        gtkmm30>=3D0:x11-toolkits/gtkmm30
XRUN_DEPENDS+=3D  gtkmm30>=3D0:x11-toolkits/gtkmm30
X
XBUILD_DEPENDS+=3D        gtksourceviewmm3>=3D0:x11-toolkits/gtksourceviewm=
m3
XRUN_DEPENDS+=3D  gtksourceviewmm3>=3D0:x11-toolkits/gtksourceviewmm3

There is a helper for this.  See USE_GNOME.

XBUILD_DEPENDS+=3D        lldb38>=3D0:devel/lldb38
XRUN_DEPENDS+=3D  lldb38>=3D0:devel/lldb38

This should be removed. It's part of the devel/llvm* ports.

XBUILD_DEPENDS+=3D        llvm39>=3D0:devel/llvm39
XRUN_DEPENDS+=3D  llvm39>=3D0:devel/llvm39

Should be a LIB_DEPENDS too.  If possible try to use devel/llvm40.

XMAKE_JOBS_SAFE=3D        yes

Remove this.  It doesn't do anything.

XWRKSRC=3D        ${WRKDIR}/${PORTNAME}-${PORTVERSION}
X
XUSE_GITHUB=3D    nodefault
...
XGH_ACCOUNT=3D    cppit:jucipp,libclangmm eidheim:tiny_process_library
XGH_PROJECT=3D    jucipp:jucipp libclangmm:libclangmm
tiny-process-library:tiny_process_library
XGH_TAGNAME=3D    v1.2.3:jucipp 1ef0424:libclangmm 8025c45:tiny_process_lib=
rary
...
Xpost-extract:
X       @${MV} ${WRKSRC_libclangmm} ${WRKSRC}/libclangmm
X       @${MV} ${WRKSRC_tiny_process_library} ${WRKSRC}/tiny-process-library
X

Better use GH_TUPLE for this.  It's much cleaner and you don't need to
move them in post-extract.

X.include <bsd.port.options.mk>
X
X.if ${PORT_OPTIONS:MDOXYGEN}
XBUILD_DEPENDS+=3D        doxygen:devel/doxygen
X.endif

This can be replaced by an options helper i.e.
DOXYGEN_BUILD_DEPENDS=3D    doxygen:devel/doxygen

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-215878-13-tMGWRqnJYf>