Date: Tue, 22 Sep 2015 20:13:56 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Mark Felder <feld@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r397543 - in head/math: . z3 z3/files Message-ID: <7fni-9va3-wny@FreeBSD.org> In-Reply-To: <201509221543.t8MFhIke005505@repo.freebsd.org> (Mark Felder's message of "Tue, 22 Sep 2015 15:43:18 %2B0000 (UTC)") References: <201509221543.t8MFhIke005505@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
=3D=3D=3D=3D> Running Q/A tests (stage-qa)
Warning: 'bin/z3' is not stripped consider trying INSTALL_TARGET=3Dinstall-=
strip or using ${STRIP_CMD}
Warning: 'lib/libz3.so' is not stripped consider trying INSTALL_TARGET=3Din=
stall-strip or using ${STRIP_CMD}
Warning: 'lib/python2.7/site-packages/libz3.so' is not stripped consider tr=
ying INSTALL_TARGET=3Dinstall-strip or using ${STRIP_CMD}
Mark Felder <feld@FreeBSD.org> writes:
> +PORTNAME=3D z3
> +PORTVERSION=3D 4.4.0
[...]
> +GH_TAGNAME=3D z3-${PORTVERSION}
Porter's Handbook advises to use DISTVERSION*FIX in such cases which'd
deduplicate version from distinfo.
> +LICENSE=3D MIT
MIT varies just like BSD. If possible specify LICENSE_FILE.
https://fedoraproject.org/wiki/Licensing:MIT
> +.if defined(WITH_DEBUG)
> +CONFIGURE_ARGS+=3D --debug
> +.endif
WITH_* conditionals are old-style options, from pre-optionsNG era.
Why STATIC is advertised while DEBUG is not?
> +pre-build:
> + ${MKDIR} ${STAGEDIR}/${PYTHON_SITELIBDIR}
%%PYTHON_SITELIBDIR%% !=3D ${PYTHON_SITELIBDIR}. The former refers to PREFIX
while the latter to LOCALBASE. Checking with |poudriere testport -P|
suggests one more change is necessary.
There's no need for path separator after ${STAGEDIR}.
Index: math/z3/Makefile
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- math/z3/Makefile (revision 397555)
+++ math/z3/Makefile (working copy)
@@ -2,6 +2,7 @@
=20
PORTNAME=3D z3
PORTVERSION=3D 4.4.0
+DISTVERSIONPREFIX=3D ${PORTNAME}-
CATEGORIES=3D math
=20
MAINTAINER=3D 6yearold@gmail.com
@@ -8,16 +9,18 @@ MAINTAINER=3D 6yearold@gmail.com
COMMENT=3D Z3 Theorem Prover
=20
LICENSE=3D MIT
+LICENSE_FILE=3D ${WRKSRC}/LICENSE.txt
=20
USE_GITHUB=3D yes
GH_ACCOUNT=3D Z3Prover
=2DGH_TAGNAME=3D z3-${PORTVERSION}
=20
=2DOPTIONS_DEFINE=3D STATIC
+OPTIONS_DEFINE=3D DEBUG STATIC
=20
OPTIONS_DEFAULT=3D STATIC
OPTIONS_SUB=3D yes
=20
+DEBUG_CONFIGURE_ON=3D --debug
+
STATIC_DESC=3D Build static z3 library
STATIC_CONFIGURE_ON=3D --staticlib
=20
@@ -32,13 +35,14 @@ USE_LDCONFIG=3D yes
BUILD_WRKSRC=3D ${WRKSRC}/build
INSTALL_WRKSRC=3D ${WRKSRC}/build
=20
=2D.if defined(WITH_DEBUG)
=2DCONFIGURE_ARGS+=3D --debug
=2D.endif
=2D
USES=3D python
=20
pre-build:
=2D ${MKDIR} ${STAGEDIR}/${PYTHON_SITELIBDIR}
+ ${MKDIR} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}
=20
+post-install:
+ ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/z3
+ ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libz3.so
+ ${STRIP_CMD} ${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}/libz3.so
+
.include <bsd.port.mk>
Index: math/z3/distinfo
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- math/z3/distinfo (revision 397555)
+++ math/z3/distinfo (working copy)
@@ -1,2 +1,2 @@
=2DSHA256 (Z3Prover-z3-4.4.0-z3-4.4.0_GH0.tar.gz) =3D 65b72f9eb0af50949e504=
b47080fb3fc95f11c435633041d9a534473f3142cba
=2DSIZE (Z3Prover-z3-4.4.0-z3-4.4.0_GH0.tar.gz) =3D 3060731
+SHA256 (Z3Prover-z3-z3-4.4.0_GH0.tar.gz) =3D 65b72f9eb0af50949e504b47080fb=
3fc95f11c435633041d9a534473f3142cba
+SIZE (Z3Prover-z3-z3-4.4.0_GH0.tar.gz) =3D 3060731
Index: math/z3/files/patch-scripts_mk__util.py
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
=2D-- math/z3/files/patch-scripts_mk__util.py (revision 397555)
+++ math/z3/files/patch-scripts_mk__util.py (working copy)
@@ -1,5 +1,14 @@
--- scripts/mk_util.py.orig 2015-04-29 14:40:46 UTC
+++ scripts/mk_util.py
+@@ -41,7 +41,7 @@ CXX_COMPILERS=3D['g++', 'clang++']
+ C_COMPILERS=3D['gcc', 'clang']
+ JAVAC=3DNone
+ JAR=3DNone
+-PYTHON_PACKAGE_DIR=3Ddistutils.sysconfig.get_python_lib()
++PYTHON_PACKAGE_DIR=3Ddistutils.sysconfig.get_python_lib(prefix=3Dgetenv("=
PREFIX", None))
+ BUILD_DIR=3D'build'
+ REV_BUILD_DIR=3D'..'
+ SRC_DIR=3D'src'
@@ -948,7 +948,7 @@ class LibComponent(Component):
=20=20
def mk_install(self, out):
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJWAZplXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bzJIH/1XxhGvPIDPoD+uO5s4jXUx0
xx/4QcGQn11n4LNjOsU5VTd9+xjKZZGBQAPIX5gQBQ85EAHk0CLEpEeE3GrMJZIK
JHVUdg1nqwTKMmf9FbqX8uNJvz/s1OhEHz2vYznEnsJj6lhSobXgmxgDup+eIezg
hq5XF4gPBfjoeVZ4vyS4s0dojzJh/eYl4+TYYoc0L1oReolfOaao/WJsKhkwd6dh
wYlRcalZOrOjH+fUKf5TC3SSYty0XoLNFDiA7yWhUqem84VW3fvFlmsixkEqkVo+
7JOfr+KUpCKoZ7Sv59SqKzqi7JjoP9X3c8+fFPHyrXGvg7d1KDeXL9WTfuZGBiw=
=wgDo
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7fni-9va3-wny>