From owner-svn-src-all@freebsd.org Thu Nov 24 09:26:34 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D3E0CC503B4; Thu, 24 Nov 2016 09:26:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FEB928D; Thu, 24 Nov 2016 09:26:34 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id uAO9QOLR011357 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 24 Nov 2016 11:26:25 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua uAO9QOLR011357 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id uAO9QOOV011308; Thu, 24 Nov 2016 11:26:24 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 24 Nov 2016 11:26:24 +0200 From: Konstantin Belousov To: Bryan Drewery Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r308687 - head/libexec/rtld-elf Message-ID: <20161124092624.GP54029@kib.kiev.ua> References: <201611150937.uAF9bZPg082363@repo.freebsd.org> <19b061c5-cd2b-f098-e8b1-aca308e61c31@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19b061c5-cd2b-f098-e8b1-aca308e61c31@FreeBSD.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 09:26:34 -0000 On Wed, Nov 23, 2016 at 11:06:53AM -0800, Bryan Drewery wrote: > On 11/15/2016 1:37 AM, Konstantin Belousov wrote: > > Author: kib > > Date: Tue Nov 15 09:37:35 2016 > > New Revision: 308687 > > URL: https://svnweb.freebsd.org/changeset/base/308687 > > > > Log: > > Update hint to utilize user variable. > > > > Sponsored by: The FreeBSD Foundation > > MFC after: 1 week > > > > Modified: > > head/libexec/rtld-elf/Makefile > > > > Modified: head/libexec/rtld-elf/Makefile > > ============================================================================== > > --- head/libexec/rtld-elf/Makefile Tue Nov 15 09:20:28 2016 (r308686) > > +++ head/libexec/rtld-elf/Makefile Tue Nov 15 09:37:35 2016 (r308687) > > @@ -2,7 +2,7 @@ > > > > # Use the following command to build local debug version of dynamic > > # linker: > > -# make DEBUG_FLAGS=-g DEBUG=-DDEBUG MK_TESTS=no all > > +# make DEBUG_FLAGS=-g DEBUG=-DDEBUG WITHOUT_TESTS=yes all > > What prompted this change? Passing MK_TESTS=no should work fine. I thought that the intent was to expose WITH_/WITHOUT_ knobs to users, and keep MK_ to internal build machinery. This most likely come from reading commit logs which I cannot dig now. For start, only WITH_/WITHOUT_ are documented in src.conf. Second, the very beginning of src.opts.mk says # Users define WITH_FOO and WITHOUT_FOO on the command line or in /etc/src.conf # and /etc/make.conf files. These translate in the build system to MK_FOO={yes,no} # with sensible (usually) defaults. Then it adds # Define MK_* variables (which are either "yes" or "no") for users # to set via WITH_*/WITHOUT_* in /etc/src.conf and override in the # make(1) environment. IMO it is relatively easy to make the same conclusion as I did, from the text above. > > > > > .include > > PACKAGE= clibs > > > > > -- > Regards, > Bryan Drewery >