From owner-cvs-all@FreeBSD.ORG Mon Feb 14 23:13:02 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E033816A4D3 for ; Mon, 14 Feb 2005 23:13:02 +0000 (GMT) Received: from mail28.sea5.speakeasy.net (mail28.sea5.speakeasy.net [69.17.117.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id A2CF243D68 for ; Mon, 14 Feb 2005 23:13:01 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 30835 invoked from network); 14 Feb 2005 23:13:01 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail28.sea5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 14 Feb 2005 23:13:00 -0000 Received: from hydrogen.funkthat.com (mtuhkt@localhost.funkthat.com [127.0.0.1])j1END0GH042399; Mon, 14 Feb 2005 15:13:00 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id j1ENCx0E042398; Mon, 14 Feb 2005 15:12:59 -0800 (PST) Date: Mon, 14 Feb 2005 15:12:59 -0800 From: John-Mark Gurney To: Maxime Henrion Message-ID: <20050214231259.GH40468@funkthat.com> References: <421104E5.6040705@marcuscom.com> <20050214224901.GC61763@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050214224901.GC61763@elvis.mu.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: src-committers@FreeBSD.org cc: cvs-src@FreeBSD.org cc: Alfred Perlstein cc: Scott Long cc: cvs-all@FreeBSD.org cc: Daniel Eischen cc: Joe Marcus Clarke Subject: Re: cvs commit: src/lib/libpthread/thread thr_attr_init.c thr_init.c thr_private.h thr_stack.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Feb 2005 23:13:03 -0000 Maxime Henrion wrote this message on Mon, Feb 14, 2005 at 23:49 +0100: > I entirely understand this and when I asked you why you weren't using > pthread_attr_setstacksize() it was out of curiosity. Anyways, I'm > surprised there's still an argument about this. __FreeBSD_version bumps > are cheap, and if it can help reduce the maintainance burden of a port, > I'm all for it. My point behind not doing a version bump is that if there is knowledge that the program needs a large/small stack, then it should ALWAYS request the stack size so that it is truely portable to all platforms.. instead of trying to berate OS xyz into increasing their default stack size... or end up breaking because this program tried to create 5000 threads, but failed because each stack took up 1MB and required 5GB of ram on a 32bit system.... If the patch is applicable before the default change, then it is applicable after, and if the patch is applicable after the default change, it was applicable before... -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."