From owner-freebsd-amd64@FreeBSD.ORG  Sun Jul 18 19:35:20 2004
Return-Path: <owner-freebsd-amd64@FreeBSD.ORG>
Delivered-To: freebsd-amd64@freebsd.org
Received: from green.homeunix.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2237616A4CE; Sun, 18 Jul 2004 19:35:20 +0000 (GMT)
Received: from green.homeunix.org (green@localhost [127.0.0.1])
	by green.homeunix.org (8.12.11/8.12.11) with ESMTP id i6IJZJ2F056143;
	Sun, 18 Jul 2004 15:35:19 -0400 (EDT)
	(envelope-from green@green.homeunix.org)
Received: (from green@localhost)
	by green.homeunix.org (8.12.11/8.12.11/Submit) id i6IJZEcF056136;
	Sun, 18 Jul 2004 15:35:14 -0400 (EDT)
	(envelope-from green)
Date: Sun, 18 Jul 2004 15:35:13 -0400
From: Brian Fundakowski Feldman <green@freebsd.org>
To: "Bjoern A. Zeeb" <bzeeb-lists@lists.zabbadoz.net>
Message-ID: <20040718193513.GV1626@green.homeunix.org>
References: <Pine.BSF.4.53.0407181443330.43309@e0-0.zab2.int.zabbadoz.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.BSF.4.53.0407181443330.43309@e0-0.zab2.int.zabbadoz.net>
User-Agent: Mutt/1.5.6i
cc: FreeBSD current mailing list <freebsd-current@freebsd.org>
cc: FreeBSD amd64 mailing list <freebsd-amd64@freebsd.org>
Subject: Re: kldunload if_sk -> LOR & panic
X-BeenThere: freebsd-amd64@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting FreeBSD to the AMD64 platform <freebsd-amd64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-amd64>
List-Post: <mailto:freebsd-amd64@freebsd.org>
List-Help: <mailto:freebsd-amd64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Jul 2004 19:35:20 -0000

On Sun, Jul 18, 2004 at 03:11:22PM +0000, Bjoern A. Zeeb wrote:
> Hi,
> 
> tried to unload if_sk for testing the newly built module with dwhite's
> locking patch (will be loaded after reset now :( ).
> resulted in this on my amd64:
> 
> --- cut ---
> noc# kldunload if_sk
> e1000phy0: detached
> miibus0: detached
> lock order reversal
>  1st 0xffffff0030ac7870 skc0 (network driver) @ sys/pci/if_sk.c:2604
>  2nd 0xffffff0000b91af0 radix node head (radix node head) @ sys/netinet/in_rmx.c:391
> Stack backtrace:
> witness_checkorder() at witness_checkorder+0x4a6
> _mtx_lock_flags() at _mtx_lock_flags+0x39
> in_ifadown() at in_ifadown+0x5b
> in_control() at in_control+0x81c
> if_detach() at if_detach+0x50b
> ether_ifdetach() at ether_ifdetach+0x25
> sk_detach() at sk_detach+0x6d
> (null)() at 0
> null_method() at null_method

At the point where it's actually detaching, once it's detached the methods
that access its softc, it should drop its softc lock before calling the
network-level detach routines.

-- 
Brian Fundakowski Feldman                           \'[ FreeBSD ]''''''''''\
  <> green@FreeBSD.org                               \  The Power to Serve! \
 Opinions expressed are my own.                       \,,,,,,,,,,,,,,,,,,,,,,\