From owner-freebsd-bugs@FreeBSD.ORG  Fri Oct 27 15:48:43 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@FreeBSD.org
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 63E7016A407;
	Fri, 27 Oct 2006 15:48:43 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0F84343D45;
	Fri, 27 Oct 2006 15:48:42 +0000 (GMT) (envelope-from sam@errno.com)
Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id k9RFmeG6007026
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Fri, 27 Oct 2006 08:48:42 -0700 (PDT) (envelope-from sam@errno.com)
Message-ID: <45422A58.40709@errno.com>
Date: Fri, 27 Oct 2006 08:48:40 -0700
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 1.5.0.7 (X11/20060920)
MIME-Version: 1.0
To: Ruslan Ermilov <ru@FreeBSD.org>
References: <05e201c6f9ac$581944e0$609b65c1@vpe.de>
	<200610270901.k9R91pTp083632@freefall.freebsd.org>
	<05ca01c6f9ab$6d8def20$609b65c1@vpe.de>
	<20061027095910.GD6613@rambler-co.ru>
In-Reply-To: <20061027095910.GD6613@rambler-co.ru>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-bugs@FreeBSD.org, Helmut Schneider <jumper99@gmx.de>
Subject: Re: misc/104854: "make release" custom kernel unsuccessful
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Oct 2006 15:48:43 -0000

Ruslan Ermilov wrote:
> On Fri, Oct 27, 2006 at 11:36:49AM +0200, Helmut Schneider wrote:
>> Well, then either I do not understand that design, or I do something 
>> completely wrong (if so I appologize):
>>
>> mkdir ${RD}/kernels
>> for i in ${KERNELS_BASE} ${KERNELS}; do \
>>    mkdir -p ${RD}/kernels/$${i}; \
>> done
>>
>> KERNELS_BASE is set to $MY_CUSTOM_KERNEL.
>> KERNELS is not mandatory and never set, so it is empty.
>>
>> => the only directory which is created is $MY_CUSTOM_KERNEL. The directory 
>> GENERIC will not be created.
>>
>> # Build boot and install floppies.
>> floppies.1:
>>        @gzip -9nc ${RD}/kernels/GENERIC/kernel > ${RD}/kernels/kernel.gz
>>
>> fails.
>>
>> => make release fails.
>>
>> make CHROOTDIR=/home/release CVSROOT=/usr BUILDNAME=6.1-RELEASE 
>> RELEASETAG=RELENG_6_1 EXTPORTSDIR=/usr/ports EXTSRCDIR=/usr/src 
>> KERNELS_BASE=IBM_HS20_SMP NODOC=YES NOPORTS=YES MAKE_ISOS=YES release
>>
>> Do I have to set KERNELS=$CUSTOM_KERNEL instead of 
>> KERNELS_BASE=$CUSTOM_KERNEL? ("make release" takes ages so I was not able 
>> to test that by now) 
> 
> On Fri, Oct 27, 2006 at 11:43:22AM +0200, Helmut Schneider wrote:
>> Sorry, forget that one, wasn't able to read the full posting (especially 
>> the part of man release)... :( 
> 
> :-)  I agree that there's still a bug in release/Makefile: it
> allows to override KERNELS_BASE but assumes later that GENERIC
> is always part of it.  A proper fix is to make KERNELS_BASE not
> overridable.  Sam, do you remember why you made it overridable?

Sorry, I do not recall.  John Baldwin was involved too I believe; maybe
he remembers.

	Sam