Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 19 Oct 2012 13:34:38 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Alberto Villa <avilla@freebsd.org>
Cc:        acpi@freebsd.org, freebsd-acpi@freebsd.org, Juergen Lock <nox@jelal.kn-bremen.de>, mobile@freebsd.org
Subject:   Re: Dell acpi_video patch
Message-ID:  <201210191334.38712.jhb@freebsd.org>
In-Reply-To: <CAJp7RHZ69okYaTXsqjkGX%2BOzoAZWNTNc1Qip%2BMof3DkLD0SVDA@mail.gmail.com>
References:  <20121005215316.GA38707@triton8.kn-bremen.de> <201210121006.17276.jhb@freebsd.org> <CAJp7RHZ69okYaTXsqjkGX%2BOzoAZWNTNc1Qip%2BMof3DkLD0SVDA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, October 19, 2012 11:23:57 am Alberto Villa wrote:
> On Fri, Oct 12, 2012 at 4:06 PM, John Baldwin <jhb@freebsd.org> wrote:
> > I think this is correct, but in we need to do more to properly handle that
> > flag (DOD_DEVID_SCHEME_STD).  Specifically, we shouldn't trust any bits in the
> > device ID unless that bit is set (except for the special case of
> > DOD_DEVID_LCD) as per my reading of the _DOD description in the ACPI 3.0b
> > spec.  I think this larger patch will do that while also fixing your case:
> 
> By the way, it looks like also 0x0100 and 0x0200 should be handled as
> legacy values:
> 
> 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=include/acpi/video.h;h=61109f2609fc3ee446ec43e242875b28ae719344;hb=HEAD
> 
> 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/acpi/video.c;h=f94d4c818fc74dc9a076e8f67fe98d7bc6620a61;hb=HEAD

I considered that, but 1) it wouldn't help your laptop, and 2) the ACPI 3.0b
spec where bit 31 is added specifically states (in the Note 3 I included in
my prior e-mail) that 0x110 is the only valid legacy ID.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210191334.38712.jhb>