From owner-freebsd-acpi@FreeBSD.ORG  Fri Oct 19 18:12:40 2012
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: acpi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id C7A3D649;
 Fri, 19 Oct 2012 18:12:40 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
 [IPv6:2001:470:1f10:75::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 9783A8FC19;
 Fri, 19 Oct 2012 18:12:40 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 00282B98E;
 Fri, 19 Oct 2012 14:12:40 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Alberto Villa <avilla@freebsd.org>
Subject: Re: Dell acpi_video patch
Date: Fri, 19 Oct 2012 13:34:38 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p20; KDE/4.5.5; amd64; ; )
References: <20121005215316.GA38707@triton8.kn-bremen.de>
 <201210121006.17276.jhb@freebsd.org>
 <CAJp7RHZ69okYaTXsqjkGX+OzoAZWNTNc1Qip+Mof3DkLD0SVDA@mail.gmail.com>
In-Reply-To: <CAJp7RHZ69okYaTXsqjkGX+OzoAZWNTNc1Qip+Mof3DkLD0SVDA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201210191334.38712.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 19 Oct 2012 14:12:40 -0400 (EDT)
Cc: acpi@freebsd.org, freebsd-acpi@freebsd.org,
 Juergen Lock <nox@jelal.kn-bremen.de>, mobile@freebsd.org
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-acpi>,
 <mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
 <mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Oct 2012 18:12:40 -0000

On Friday, October 19, 2012 11:23:57 am Alberto Villa wrote:
> On Fri, Oct 12, 2012 at 4:06 PM, John Baldwin <jhb@freebsd.org> wrote:
> > I think this is correct, but in we need to do more to properly handle that
> > flag (DOD_DEVID_SCHEME_STD).  Specifically, we shouldn't trust any bits in the
> > device ID unless that bit is set (except for the special case of
> > DOD_DEVID_LCD) as per my reading of the _DOD description in the ACPI 3.0b
> > spec.  I think this larger patch will do that while also fixing your case:
> 
> By the way, it looks like also 0x0100 and 0x0200 should be handled as
> legacy values:
> 
> 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=include/acpi/video.h;h=61109f2609fc3ee446ec43e242875b28ae719344;hb=HEAD
> 
> 
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/acpi/video.c;h=f94d4c818fc74dc9a076e8f67fe98d7bc6620a61;hb=HEAD

I considered that, but 1) it wouldn't help your laptop, and 2) the ACPI 3.0b
spec where bit 31 is added specifically states (in the Note 3 I included in
my prior e-mail) that 0x110 is the only valid legacy ID.

-- 
John Baldwin